From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1765827AbcLWL7k (ORCPT <rfc822;w@1wt.eu>);
        Fri, 23 Dec 2016 06:59:40 -0500
Received: from mx2.suse.de ([195.135.220.15]:38345 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1762370AbcLWL7j (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 23 Dec 2016 06:59:39 -0500
Date: Fri, 23 Dec 2016 12:59:35 +0100
From: Petr Mladek <pmladek@suse.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: Jessica Yu <jeyu@redhat.com>, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] Fix usage of true and false as field names in struct
 taint_flag
Message-ID: <20161223115935.GF2541@linux.suse>
References: <66759.1482432998@turing-police.cc.vt.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <66759.1482432998@turing-police.cc.vt.edu>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu 2016-12-22 13:56:38, Valdis Kletnieks wrote:
> commit 7fd8329ba502ef76dd91db561c7aed696b2c7720
> Author: Petr Mladek <pmladek@suse.com>
> Date:   Wed Sep 21 13:47:22 2016 +0200
> 
>     taint/module: Clean up global and module taint flags handling
> 
> Contains this chunk:

Information about a past commits is usually writted using
the following notation:

The commit 7fd8329ba502ef76dd ("taint/module: Clean up global and
module taint flags handling") contains this chunk: 

See also Documentation/process/submitting-patches.rst

> --- a/include/linux/kernel.h
  ^^^

This delimits a standard signature and the commit message below
will be ignored by git. You should omit it in the commit message.

> 
> +struct taint_flag {
> +       char true;      /* character printed when tainted */
> +       char false;     /* character printed when not tainted */
> +       bool module;    /* also show as a per-module taint flag */
> +};
> 
> and hilarity ensues when an out-of-tree module has this:
> 
> # ifndef true
> #  define true  (1)
> # endif
> # ifndef false
> #  define false (0)
> # endif
> 
> Change the field names to not shadow something likely to be used
> by third-party modules.
> 
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

The change itself looks fine. With the above fixes in the commit
message, feel free to use

Reviewed-by: Petr Mladek <pmladek@suse.com>

Thanks for the fix.

Best Regards,
Petr