From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, Wenyou Yang <wenyou.yang@atmel.com>
Subject: Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly
Date: Fri, 23 Dec 2016 19:05:10 +0100 [thread overview]
Message-ID: <20161223180510.GE26271@kroah.com> (raw)
In-Reply-To: <0697753c-ea66-805d-a366-7de708efc066@axentia.se>
On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote:
> On 2016-12-22 18:27, Greg Kroah-Hartman wrote:
> > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote:
> >> The gpiod_get* function family does not want the -gpio suffix.
> >> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional.
> >> The descriptor based APIs handle active high/low automatically.
> >> The vbus-gpios are output, request enable while getting the gpio.
> >> Don't try to get any vbus-gpios for ports outside num-ports.
> >>
> >> WTF? Big sigh.
> >>
> >> Fixes: 054d4b7b577d ("usb: ohci-at91: Use descriptor-based gpio APIs")
> >> Signed-off-by: Peter Rosin <peda@axentia.se>
> >> ---
> >>
> >> Hi!
> >>
> >> Resending this, since the only response I've got is that the merge
> >> window is open and that this patch has been put on hold due to that.
> >> But I think this regression (which happend between v4.9 and current
> >> master) should be fixed before the merge window closes.
> >
> > I don't merge patches before -rc1 comes out, sorry, people should have
> > tested linux-next better :)
>
> Neat, shift the blame for the shit patch over to the messenger :)
Not at all, I blame the original developer :)
> > I'll catch up the first week of January, relax.
>
> As we all know, unrelated regressions are painful when trying to locate
> other problems. It's seems silly to have a few extra for no good reason.
I am supposed to be on vacation and not reading email until the 3rd of
January, relax, we will catch up on stuff like this, and other minor
things, soon enough, in plenty of time for 4.10-final.
thanks,
greg k-h
next prev parent reply other threads:[~2016-12-23 18:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 7:43 [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly Peter Rosin
2016-12-22 17:27 ` Greg Kroah-Hartman
2016-12-22 20:38 ` Peter Rosin
2016-12-23 18:05 ` Greg Kroah-Hartman [this message]
2016-12-26 5:19 ` Wenyou.Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223180510.GE26271@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peda@axentia.se \
--cc=stern@rowland.harvard.edu \
--cc=wenyou.yang@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox