From: Nils Holland <nholland@tisys.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Chris Mason <clm@fb.com>, David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org
Subject: Re: [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on)
Date: Fri, 23 Dec 2016 23:26:00 +0100 [thread overview]
Message-ID: <20161223222559.GA5568@teela.multi.box> (raw)
In-Reply-To: <20161223144738.GB23117@dhcp22.suse.cz>
On Fri, Dec 23, 2016 at 03:47:39PM +0100, Michal Hocko wrote:
>
> Nils, even though this is still highly experimental, could you give it a
> try please?
Yes, no problem! So I kept the very first patch you sent but had to
revert the latest version of the debugging patch (the one in
which you added the "mm_vmscan_inactive_list_is_low" event) because
otherwise the patch you just sent wouldn't apply. Then I rebooted with
memory cgroups enabled again, and the first thing that strikes the eye
is that I get this during boot:
[ 1.568174] ------------[ cut here ]------------
[ 1.568327] WARNING: CPU: 0 PID: 1 at mm/memcontrol.c:1032 mem_cgroup_update_lru_size+0x118/0x130
[ 1.568543] mem_cgroup_update_lru_size(f4406400, 2, 1): lru_size 0 but not empty
[ 1.568754] Modules linked in:
[ 1.568922] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-gentoo #6
[ 1.569052] Hardware name: Hewlett-Packard Compaq 15 Notebook PC/21F7, BIOS F.22 08/06/2014
[ 1.571750] f44e5b84 c142bdee f44e5bc8 c1b5ade0 f44e5bb4 c103ab1d c1b583e4 f44e5be4
[ 1.572262] 00000001 c1b5ade0 00000408 c11603d8 00000408 00000000 c1b5af73 00000001
[ 1.572774] f44e5bd0 c103ab76 00000009 00000000 f44e5bc8 c1b583e4 f44e5be4 f44e5c18
[ 1.573285] Call Trace:
[ 1.573419] [<c142bdee>] dump_stack+0x47/0x69
[ 1.573551] [<c103ab1d>] __warn+0xed/0x110
[ 1.573681] [<c11603d8>] ? mem_cgroup_update_lru_size+0x118/0x130
[ 1.573812] [<c103ab76>] warn_slowpath_fmt+0x36/0x40
[ 1.573942] [<c11603d8>] mem_cgroup_update_lru_size+0x118/0x130
[ 1.574076] [<c1111467>] __pagevec_lru_add_fn+0xd7/0x1b0
[ 1.574206] [<c1111390>] ? perf_trace_mm_lru_insertion+0x150/0x150
[ 1.574336] [<c111239d>] pagevec_lru_move_fn+0x4d/0x80
[ 1.574465] [<c1111390>] ? perf_trace_mm_lru_insertion+0x150/0x150
[ 1.574595] [<c11127e5>] __lru_cache_add+0x45/0x60
[ 1.574724] [<c1112848>] lru_cache_add+0x8/0x10
[ 1.574852] [<c1102fc1>] add_to_page_cache_lru+0x61/0xc0
[ 1.574982] [<c110418e>] pagecache_get_page+0xee/0x270
[ 1.575111] [<c11060f0>] grab_cache_page_write_begin+0x20/0x40
[ 1.575243] [<c118b955>] simple_write_begin+0x25/0xd0
[ 1.575372] [<c11061b8>] generic_perform_write+0xa8/0x1a0
[ 1.575503] [<c1106447>] __generic_file_write_iter+0x197/0x1f0
[ 1.575634] [<c110663f>] generic_file_write_iter+0x19f/0x2b0
[ 1.575766] [<c11669c1>] __vfs_write+0xd1/0x140
[ 1.575897] [<c1166bc5>] vfs_write+0x95/0x1b0
[ 1.576026] [<c1166daf>] SyS_write+0x3f/0x90
[ 1.576157] [<c1ce4474>] xwrite+0x1c/0x4b
[ 1.576285] [<c1ce44c5>] do_copy+0x22/0xac
[ 1.576413] [<c1ce42c3>] write_buffer+0x1d/0x2c
[ 1.576540] [<c1ce42f0>] flush_buffer+0x1e/0x70
[ 1.576670] [<c1d0eae8>] unxz+0x149/0x211
[ 1.576798] [<c1d0e99f>] ? unlzo+0x359/0x359
[ 1.576926] [<c1ce4946>] unpack_to_rootfs+0x14f/0x246
[ 1.577054] [<c1ce42d2>] ? write_buffer+0x2c/0x2c
[ 1.577183] [<c1ce4216>] ? initrd_load+0x3b/0x3b
[ 1.577312] [<c1ce4b20>] ? maybe_link.part.3+0xe3/0xe3
[ 1.577443] [<c1ce4b67>] populate_rootfs+0x47/0x8f
[ 1.577573] [<c1000456>] do_one_initcall+0x36/0x150
[ 1.577701] [<c1ce351e>] ? repair_env_string+0x12/0x54
[ 1.577832] [<c1054ded>] ? parse_args+0x25d/0x400
[ 1.577962] [<c1ce3baf>] ? kernel_init_freeable+0x101/0x19e
[ 1.578092] [<c1ce3bcf>] kernel_init_freeable+0x121/0x19e
[ 1.578222] [<c19b0700>] ? rest_init+0x60/0x60
[ 1.578350] [<c19b070b>] kernel_init+0xb/0x100
[ 1.578480] [<c1060c7c>] ? schedule_tail+0xc/0x50
[ 1.578608] [<c19b0700>] ? rest_init+0x60/0x60
[ 1.578737] [<c19b5db7>] ret_from_fork+0x1b/0x28
[ 1.578871] ---[ end trace cf6f1adac9dfe60e ]---
The machine then continued to boot just normally, however, so I
started my ordinary tests. And in fact, they were working just fine,
i.e. no OOMing anymore, even during heavy tarball unpacking.
Would it make sense to capture more trace data for you at this point?
As I'm on the go, I don't currently have a second machine for
capturing over the network, but since we're not having OOMs or other
issues now, capturing to file should probably work just fine.
I'll keep the patch applied and see if I notice anything else that
doesn't look normal during day to day usage, especially during my
ordinary Gentoo updates, which consist of a lot of fetching /
unpacking / building, and in the recent past had been very problematic
(in fact, that was where the problem first struck me and the "heavy
tarball unpacking" test was then just what I distilled it down to
in order to manually reproduce this with the least time and effort
possible).
Greetings
Nils
next prev parent reply other threads:[~2016-12-23 22:26 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 22:57 OOM: Better, but still there on 4.9 Nils Holland
2016-12-16 7:39 ` Michal Hocko
2016-12-16 15:58 ` OOM: Better, but still there on Michal Hocko
2016-12-16 15:58 ` [PATCH 1/2] mm: consolidate GFP_NOFAIL checks in the allocator slowpath Michal Hocko
2016-12-16 15:58 ` [PATCH 2/2] mm, oom: do not enfore OOM killer for __GFP_NOFAIL automatically Michal Hocko
2016-12-16 17:31 ` Johannes Weiner
2016-12-16 22:12 ` Michal Hocko
2016-12-17 11:17 ` Tetsuo Handa
2016-12-18 16:37 ` Michal Hocko
2016-12-16 18:47 ` OOM: Better, but still there on Nils Holland
2016-12-17 0:02 ` Michal Hocko
2016-12-17 12:59 ` Nils Holland
2016-12-17 14:44 ` Tetsuo Handa
2016-12-17 17:11 ` Nils Holland
2016-12-17 21:06 ` Nils Holland
2016-12-18 5:14 ` Tetsuo Handa
2016-12-19 13:45 ` Michal Hocko
2016-12-20 2:08 ` Nils Holland
2016-12-21 7:36 ` Michal Hocko
2016-12-21 11:00 ` Tetsuo Handa
2016-12-21 11:16 ` Michal Hocko
2016-12-21 14:04 ` Chris Mason
2016-12-22 10:10 ` Nils Holland
2016-12-22 10:27 ` Michal Hocko
2016-12-22 10:35 ` Nils Holland
2016-12-22 10:46 ` Tetsuo Handa
2016-12-22 19:17 ` Michal Hocko
2016-12-22 21:46 ` Nils Holland
2016-12-23 10:51 ` Michal Hocko
2016-12-23 12:18 ` Nils Holland
2016-12-23 12:57 ` Michal Hocko
2016-12-23 14:47 ` [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on) Michal Hocko
2016-12-23 22:26 ` Nils Holland [this message]
2016-12-26 12:48 ` Michal Hocko
2016-12-26 18:57 ` Nils Holland
2016-12-27 8:08 ` Michal Hocko
2016-12-27 11:23 ` Nils Holland
2016-12-27 11:27 ` Michal Hocko
2016-12-27 15:55 ` Michal Hocko
2016-12-27 16:28 ` [PATCH] mm, vmscan: consider eligible zones in get_scan_count kbuild test robot
2016-12-28 8:51 ` Michal Hocko
2016-12-27 19:33 ` [RFC PATCH] mm, memcg: fix (Re: OOM: Better, but still there on) Nils Holland
2016-12-28 8:57 ` Michal Hocko
2016-12-29 1:20 ` Minchan Kim
2016-12-29 9:04 ` Michal Hocko
2016-12-30 2:05 ` Minchan Kim
2016-12-30 10:40 ` Michal Hocko
2016-12-29 0:31 ` Minchan Kim
2016-12-29 0:48 ` Minchan Kim
2016-12-29 8:52 ` Michal Hocko
2016-12-30 10:19 ` Mel Gorman
2016-12-30 11:05 ` Michal Hocko
2016-12-30 12:43 ` Mel Gorman
2016-12-25 22:25 ` [lkp-developer] [mm, memcg] d18e2b2aca: WARNING:at_mm/memcontrol.c:#mem_cgroup_update_lru_size kernel test robot
2016-12-26 12:26 ` Michal Hocko
2016-12-26 12:50 ` Michal Hocko
2016-12-18 0:28 ` OOM: Better, but still there on Xin Zhou
2016-12-16 18:15 ` OOM: Better, but still there on 4.9 Chris Mason
2016-12-16 22:14 ` Michal Hocko
2016-12-16 22:47 ` Chris Mason
2016-12-16 23:31 ` Michal Hocko
2016-12-16 19:50 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223222559.GA5568@teela.multi.box \
--to=nholland@tisys.org \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=hannes@cmpxchg.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).