From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753258AbcL0U6d (ORCPT <rfc822;w@1wt.eu>);
        Tue, 27 Dec 2016 15:58:33 -0500
Received: from bh-25.webhostbox.net ([208.91.199.152]:51853 "EHLO
        bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752294AbcL0U6X (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 27 Dec 2016 15:58:23 -0500
Date: Tue, 27 Dec 2016 12:58:19 -0800
From: Guenter Roeck <linux@roeck-us.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, Andrew Duggan <aduggan@synaptics.com>,
        Christopher Heiny <cheiny@synaptics.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Nick Dyer <nick@shmanahar.org>, Lyude Paul <thatslyude@gmail.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics-rmi4 - fix F03 build error when serio
 is module
Message-ID: <20161227205819.GA16929@roeck-us.net>
References: <20161227193456.GA36223@dtor-ws>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20161227193456.GA36223@dtor-ws>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-Authenticated_sender: guenter@roeck-us.net
X-OutGoing-Spam-Status: No, score=-1.0
X-AntiAbuse: This header was added to track abuse, please include it with any abuse report
X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net
X-AntiAbuse: Original Domain - vger.kernel.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - roeck-us.net
X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: guenter@roeck-us.net
X-Authenticated-Sender: bh-25.webhostbox.net: guenter@roeck-us.net
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 27, 2016 at 11:34:56AM -0800, Dmitry Torokhov wrote:
> Since F03 is a boolean, "depends" on symbols that can be modules
> do not work quite right. We can enable F03 if SERIO is built-in or
> if both RMI core and SERIO core are modules. If SERIO core is module,
> but RMI is built-in, we'll get:
> 
> drivers/built-in.o: In function `rmi_f03_attention':
> rmi_f03.c:(.text+0xf8ef8): undefined reference to `serio_interrupt'
> rmi_f03.c:(.text+0xf8fbd): undefined reference to `serio_interrupt'
> drivers/built-in.o: In function `rmi_f03_remove':
> rmi_f03.c:(.text+0xf9082): undefined reference to `serio_unregister_port'
> drivers/built-in.o: In function `rmi_f03_probe':
> rmi_f03.c:(.text+0xf9260): undefined reference to `__serio_register_port'
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/input/rmi4/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig
> index 30cc627..8993983 100644
> --- a/drivers/input/rmi4/Kconfig
> +++ b/drivers/input/rmi4/Kconfig
> @@ -41,7 +41,8 @@ config RMI4_SMB
>  
>  config RMI4_F03
>          bool "RMI4 Function 03 (PS2 Guest)"
> -        depends on RMI4_CORE && SERIO
> +	depends on RMI4_CORE
> +	depends on SERIO=y || RMI4_CORE=SERIO
>          help
>            Say Y here if you want to add support for RMI4 function 03.
>  
> -- 
> 2.8.0.rc3.226.g39d4020
> 
> 
> -- 
> Dmitry