From: Pavel Machek <pavel@ucw.cz>
To: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Cc: rpurdie@rpsys.net, jacek.anaszewski@gmail.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: Allow drivers to update the core, and generate events on changes
Date: Tue, 27 Dec 2016 22:02:45 +0100 [thread overview]
Message-ID: <20161227210245.GA7952@amd> (raw)
In-Reply-To: <5f442764-825b-1bdc-2763-1c4c8dc1c098@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1885 bytes --]
Hi!
> > Generating uevent for /sys changes does not make much sense, right?
>
> I planned to use this patch mostly for keyboard backlights, for
> which some DEs provide a UI similar to the one for screen backlights.
> Having uevents also for /sys changes means having the UI always in
> sync with the kernel/hardware, as it happens for screen backlights.
> In case of LEDs only the application changing the brightness is
> aware of the change.
>
> >> +extern void led_brightness_force_update(struct led_classdev *led_cdev,
> >> + enum led_brightness_update_reason reason);
> >
> > I see this may make some sense, but there are no uses for this in this
> > patch.
> >
> > My preffered solution would be ... for hardware that changes led
> > brightness itself, introduce a "trigger", so that userspace knows this
> > led is special, and then provide poll()able /sys fs file interested
> > parties can read.
>
> OK, I'll see if I can come up something good.
Please see this thread:
Date: Tue, 15 Nov 2016 13:06:14 +0100
From: Hans de Goede <hdegoede@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>, Jacek Anaszewski
<jacek.anaszewski@gmail.com>, Tony Lindgren
<tony@atomide.com>,
linux-leds@vger.kernel.org,
linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Darren Hart
<dvhart@infradead.org>, Hans de Goede <hdegoede@redhat.com>
Subject: Re: LEDs that change brightness "itself" -- that's a
trigger. Re: PM regression with LED changes in next-20161109
...and you may want to cc: Hans de Goede <hdegoede@redhat.com> . He is
apparently solving same problem.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-12-27 21:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 19:11 [PATCH] leds: Allow drivers to update the core, and generate events on changes Gabriele Mazzotta
2016-12-27 20:07 ` Pavel Machek
2016-12-27 20:23 ` Gabriele Mazzotta
2016-12-27 21:02 ` Pavel Machek [this message]
2016-12-27 22:57 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227210245.GA7952@amd \
--to=pavel@ucw.cz \
--cc=gabriele.mzt@gmail.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox