From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752244AbcL2F3t (ORCPT ); Thu, 29 Dec 2016 00:29:49 -0500 Received: from mail.kernel.org ([198.145.29.136]:53658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcL2F3r (ORCPT ); Thu, 29 Dec 2016 00:29:47 -0500 Date: Thu, 29 Dec 2016 07:29:40 +0200 From: Leon Romanovsky To: Kenneth Lee Cc: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, robin.murphy@arm.com, jroedel@suse.de, egtvedt@samfundet.no, vgupta@synopsys.com, dave.hansen@linux.intel.com, lstoakes@gmail.com, krzk@kernel.org, sebott@linux.vnet.ibm.com, markb@mellanox.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Message-ID: <20161229052940.GH26885@mtr-leonro.local> References: <1482978283-201678-1-git-send-email-liguozhu@hisilicon.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PW0Eas8rCkcu1VkF" Content-Disposition: inline In-Reply-To: <1482978283-201678-1-git-send-email-liguozhu@hisilicon.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PW0Eas8rCkcu1VkF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Dec 29, 2016 at 10:24:43AM +0800, Kenneth Lee wrote: > There are two bugfixes in this patch: > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put > back. > 2. When the memory allocation fail, the pid also should be put back before > exit. > > Signed-off-by: Kenneth Lee Hi Kenneth, Thank you for resubmitting it. This fix is important and no doubts that it will be accepted, however you need to improve the patch a little bit more. CAn you please resubmit it according to Documentation/SubmittingPatches and reviewers feedback? Haggai's Reviewed-by tag, Fixes, changelog, version in title and proper title (see it in git log for this subsystems). Thanks --PW0Eas8rCkcu1VkF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlhkn0QACgkQ5GN7iDZy WKc5GRAAr7jPy/wFzS48kwfFUp8aowwA+EKXDu+5d/M3XtRmae1gH8yIU+DCfqAj wwNYJUDcbr2QVTjaYXxPjWKUnKk6JD9ySC2bswDBzmk+uyihRkg2rT9sVKHyjg4v ut+vV9QO7d4hJfURoZk6rRBapgYL0oibKYswHYwksar77Te5CYoAmEbfa+WIGFUr bMtUem0Tc+0Atpv6eUcqTqKsacicMor5t+1DRj4bl/cj/2MStQ82bKz6YsiORI1B GwuJn21yOjvV4J8SHD4c2upJ90SWxuxi4Tj4vlzfEYjtah6R45wnIBbgrBKjaLIs pWYMJMfyAM0Uyyfz8Ac5FvT3y2MLCR60kPCVEsSQ8cokPfXDAT1c3pd32rFRFUxj /e/a/88ZcUGZxF6fBalTAcYVwUYb+UDLnP8y3aCkgH6lCIQsYSRQzAvtenBoqzK8 StxPEouQ8yZoqEYKYbLe2U0hceQOF5+iHvwK/ngpIn/nHLhogk7dQUqJ+v4c9QeO se6dQnHpN+vEZPBifaF+KcaC4W1+mwgRKaEd4EEHjI7bMzFWKTuqqCR67Z8ntD4/ R1bGtWXDtTh8rAZrC2r1HJwwlyMLdo1aFTLbtm6GNYzdjcZRswIm0nG9o50OVQUv YWY1orNcIAM3FIRV89YE/5Uadn4W5/EQUqohXE7kNZOKRppK6W4= =AHoF -----END PGP SIGNATURE----- --PW0Eas8rCkcu1VkF--