From: Guenter Roeck <linux@roeck-us.net>
To: Alexander Koch <mail@alexanderkoch.net>
Cc: linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, jdelvare@suse.com, trivial@kernel.org
Subject: Re: [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup
Date: Thu, 29 Dec 2016 11:46:46 -0800 [thread overview]
Message-ID: <20161229194646.GA1575@roeck-us.net> (raw)
In-Reply-To: <3b34c8aa-9d9a-cf88-0d84-8e0d47f9bf44@alexanderkoch.net>
On Thu, Dec 29, 2016 at 07:22:12PM +0100, Alexander Koch wrote:
> On 12/26/2016 11:47 AM, Guenter Roeck wrote:
> > On 12/23/2016 02:12 PM, Alexander Koch wrote:
> >> Replace sysfs symbolic file permissions, e.g. 'S_IRUGO', by octal
> >> permissions. This fixes checkpatch.pl warnings.
> >>
> >> Signed-off-by: Alexander Koch <mail@alexanderkoch.net>
> >
> > Please do not bother with those warnings and ignore checkpatch.
> > We are in the process of doing an automated conversion.
>
> Okay, so I shall create v3 of the patchset, without these changes. I've
> found a typo in the 4th patch so I thought about going v3 anyways.
>
> I've tested operation modes 1-3 on real hardware today and found no
> issues so far, so I hope v3 will have good chances of getting accepted.
>
Pretty much. One request, though: If there is no configuration data
from DT, I would like the driver to read the mode from the chip - if for
nothing else, this will let me test all modes, but it also supports the
case where the chip is configured by BIOS/ROMMON.
Thanks,
Guenter
next prev parent reply other threads:[~2016-12-29 19:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 22:12 [RFC PATCH v2 0/4] hwmon: adc128d818: Support missing operation modes Alexander Koch
2016-12-23 22:12 ` [RFC PATCH v2 1/4] devicetree: hwmon: Add bindings for ADC128D818 Alexander Koch
2017-01-03 15:28 ` Rob Herring
2016-12-23 22:12 ` [RFC PATCH v2 2/4] hwmon: adc128d818: Implement mode selection via dt Alexander Koch
2016-12-23 22:12 ` [RFC PATCH v2 3/4] hwmon: adc128d818: Trivial code style fixup Alexander Koch
2016-12-26 10:47 ` Guenter Roeck
2016-12-29 18:22 ` Alexander Koch
2016-12-29 19:46 ` Guenter Roeck [this message]
2016-12-29 20:30 ` Alexander Koch
2016-12-30 0:55 ` Guenter Roeck
2016-12-23 22:12 ` [RFC PATCH v2 4/4] hwmon: adc128d818: Support operation modes 1-3 Alexander Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229194646.GA1575@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@alexanderkoch.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox