From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753237AbcL2WL6 (ORCPT ); Thu, 29 Dec 2016 17:11:58 -0500 Received: from mail-yw0-f196.google.com ([209.85.161.196]:36265 "EHLO mail-yw0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751172AbcL2WLU (ORCPT ); Thu, 29 Dec 2016 17:11:20 -0500 From: Tejun Heo To: lizefan@huawei.com, hannes@cmpxchg.org Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Tejun Heo Subject: [PATCH 1/3] cgroup: cosmetic update to cgroup_taskset_add() Date: Thu, 29 Dec 2016 17:11:13 -0500 Message-Id: <20161229221115.31995-2-tj@kernel.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20161229221115.31995-1-tj@kernel.org> References: <20161229221115.31995-1-tj@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cgroup_taskset_add() was using list_add_tail() when for source csets but list_move_tail() for destination. As the operations are gated by list_empty() test, list_move_tail() is equivalent to list_add_tail() here. Use list_add_tail() too for destination csets too. This doesn't cause any functional changes. Signed-off-by: Tejun Heo --- kernel/cgroup/cgroup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index d9d82e9..aed492e 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1980,8 +1980,8 @@ static void cgroup_taskset_add(struct task_struct *task, if (list_empty(&cset->mg_node)) list_add_tail(&cset->mg_node, &tset->src_csets); if (list_empty(&cset->mg_dst_cset->mg_node)) - list_move_tail(&cset->mg_dst_cset->mg_node, - &tset->dst_csets); + list_add_tail(&cset->mg_dst_cset->mg_node, + &tset->dst_csets); } /** -- 2.9.3