From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753600AbcL3EYW (ORCPT ); Thu, 29 Dec 2016 23:24:22 -0500 Received: from szxga03-in.huawei.com ([119.145.14.66]:10337 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753374AbcL3EYU (ORCPT ); Thu, 29 Dec 2016 23:24:20 -0500 Date: Fri, 30 Dec 2016 12:50:11 +0800 From: Kenneth Lee To: Leon Romanovsky CC: , , , , , , , , , , , , , Subject: Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get() Message-ID: <20161230045011.GA79815@Turing-Arch-b> References: <1483000048-183875-1-git-send-email-liguozhu@hisilicon.com> <20161229081756.GI26885@mtr-leonro.local> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20161229081756.GI26885@mtr-leonro.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [10.67.212.75] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Leon, 1. I do change the title except for the version number itself:) But my English is quite bad, maybe the title is still quite stupid. I can update it according to your advice. 2. I catched the bug by reading the final code, not by bisect-ing the old commit. Do you means I should find out which commit introducing the bug? It will not be easily to say which it is because it is a "missing bug", rather than a "introduced bug". Indicate the commit may not help to remove a patch/commit from the stable tree. Could you please give more suggestion? Thanks. On Thu, Dec 29, 2016 at 10:17:56AM +0200, Leon Romanovsky wrote: > Date: Thu, 29 Dec 2016 10:17:56 +0200 > From: Leon Romanovsky > To: Kenneth Lee > CC: dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, > robin.murphy@arm.com, jroedel@suse.de, egtvedt@samfundet.no, > vgupta@synopsys.com, dave.hansen@linux.intel.com, lstoakes@gmail.com, > krzk@kernel.org, sebott@linux.vnet.ibm.com, markb@mellanox.com, > linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2] ib umem: bugfix: mixed put_pid()s in ib_umem_get() > User-Agent: Mutt/1.7.2 (2016-11-26) > Message-ID: <20161229081756.GI26885@mtr-leonro.local> > > On Thu, Dec 29, 2016 at 04:27:28PM +0800, Kenneth Lee wrote: > > There are two bugfixes in this patch: > > > > 1. When the execution go to the ib_umem_odp_get() path, pid should be put > > back. > > 2. When the memory allocation fail, the pid also should be put back before > > exit. > > > > Signed-off-by: Kenneth Lee > > Reviewed-by: Haggai Eran > > --- > > Change from v1 to v2: > > Correcting the patch title and description > > I don't see any changes except version in the title. > What about anything like this? > [PATCH v3] IB/umem: Release pid in error and ODP flows > > And Fixes line please, it will help to forward it to stable trees. > > Thanks -- -Kenneth(Hisilicon)