From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755284AbdABFKx (ORCPT ); Mon, 2 Jan 2017 00:10:53 -0500 Received: from mga02.intel.com ([134.134.136.20]:53947 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750803AbdABFKw (ORCPT ); Mon, 2 Jan 2017 00:10:52 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,432,1477983600"; d="scan'208";a="918028143" Date: Mon, 2 Jan 2017 10:40:43 +0530 From: Vinod Koul To: Bhumika Goyal Cc: julia.lawall@lip6.fr, sudeep.dutt@intel.com, ashutosh.dixit@intel.com, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: misc: mic: constify mbus_hw_ops structures Message-ID: <20170102051043.GP3573@localhost> References: <1482231377-25864-1-git-send-email-bhumirks@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482231377-25864-1-git-send-email-bhumirks@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2016 at 04:26:17PM +0530, Bhumika Goyal wrote: > The fields of structure mbus_hw_ops are never modified after > initialization, so declare these structures as const. Add a const > annotation to all its initializations and uses like function arguments > and pointers. > Used Coccinelle to find all the occurences. Can you please split these per driver so that they can be merged thru their own subsystems. -- ~Vinod