From: Robin van der Gracht <robin@protonic.nl>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Fengguang Wu <fengguang.wu@intel.com>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH] auxdisplay: fix new ht16k33 build errors
Date: Mon, 2 Jan 2017 08:45:24 +0100 [thread overview]
Message-ID: <20170102084524.3d603fd3@erd979> (raw)
In-Reply-To: <18889802-a96c-b71c-31d4-5f1d94903e70@infradead.org>
On Mon, 26 Dec 2016 09:58:34 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors caused by selecting incorrect kconfig symbols.
>
> drivers/built-in.o:(.data+0x19cec): undefined reference to `sys_fillrect'
> drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea'
> drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
>
> Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Robin van der Gracht <robin@protonic.nl>
> Cc: Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
> drivers/auxdisplay/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- lnx-410-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc1/drivers/auxdisplay/Kconfig
> @@ -132,9 +132,9 @@ config HT16K33
> tristate "Holtek Ht16K33 LED controller with keyscan"
> depends on FB && OF && I2C && INPUT
> select FB_SYS_FOPS
> - select FB_CFB_FILLRECT
> - select FB_CFB_COPYAREA
> - select FB_CFB_IMAGEBLIT
> + select FB_SYS_FILLRECT
> + select FB_SYS_COPYAREA
> + select FB_SYS_IMAGEBLIT
> select INPUT_MATRIXKMAP
> select FB_BACKLIGHT
> help
Acked-by: Robin van der Gracht <robin@protonic.nl>
prev parent reply other threads:[~2017-01-02 7:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-26 17:58 [PATCH] auxdisplay: fix new ht16k33 build errors Randy Dunlap
2017-01-02 7:45 ` Robin van der Gracht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102084524.3d603fd3@erd979 \
--to=robin@protonic.nl \
--cc=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox