From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932743AbdABJyl (ORCPT ); Mon, 2 Jan 2017 04:54:41 -0500 Received: from mail-lf0-f67.google.com ([209.85.215.67]:35549 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932701AbdABJyX (ORCPT ); Mon, 2 Jan 2017 04:54:23 -0500 Date: Mon, 2 Jan 2017 10:54:20 +0100 From: Johan Hovold To: Xie Qirong Cc: "Bryan O'Donoghue" , Johan Hovold , Alex Elder , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Bryan O'Donoghue" Subject: Re: [PATCH] greybus: timesync: replace init_timer with setup_timer Message-ID: <20170102095420.GO8189@localhost> References: <20161213143957.30708-1-xieqr16@lzu.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161213143957.30708-1-xieqr16@lzu.edu.cn> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2016 at 10:39:57PM +0800, Xie Qirong wrote: > The combination of init_timer and setting up the data and function field > manually is equivalent to calling setup_timer(). This is an api > consolidation only and improves readability. > > Signed-off-by: Xie Qirong > --- > > setup_timer.cocci suggested the following improvement: > drivers/staging/greybus/timesync.c:1058:1-11: Use setup_timer function > for function on line 1059. > > Patch was compile checked with: x86_64_defconfig + CONFIG_STAGING=y, > CONFIG_GREYBUS=m > > Kernel version: 4.9.0 (localversion-next is next-20161213) > > drivers/staging/greybus/timesync.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/greybus/timesync.c b/drivers/staging/greybus/timesync.c > index 29e6c1c..af83e12 100644 > --- a/drivers/staging/greybus/timesync.c > +++ b/drivers/staging/greybus/timesync.c > @@ -1055,10 +1055,9 @@ int gb_timesync_svc_add(struct gb_svc *svc) > goto done; > } > > - init_timer(×ync_svc->ktime_timer); > - timesync_svc->ktime_timer.function = gb_timesync_ktime_timer_fn; > + setup_timer(×ync_svc->ktime_timer, gb_timesync_ktime_timer_fn, > + (unsigned long)timesync_svc); Please make sure to align the continuation line to the open parenthesis (which is the style followed in this file). > timesync_svc->ktime_timer.expires = jiffies + GB_TIMESYNC_KTIME_UPDATE; > - timesync_svc->ktime_timer.data = (unsigned long)timesync_svc; > add_timer(×ync_svc->ktime_timer); > done: > mutex_unlock(&gb_timesync_svc_list_mutex); When resending you can add my Reviewed-by: Johan Hovold Thanks, Johan