From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH perf/core] perf-probe: Fix to get correct modname from elf header
Date: Mon, 2 Jan 2017 14:09:40 -0300 [thread overview]
Message-ID: <20170102170940.GD21178@kernel.org> (raw)
In-Reply-To: <148337043836.6752.383495516397005695.stgit@devbox>
Em Tue, Jan 03, 2017 at 12:20:49AM +0900, Masami Hiramatsu escreveu:
> Since perf-probe supports cross-arch probe, it is possible to
> analyze different arch kernel image which has different
> bits-per-long. In that case, it fails to get module name
> because perf probe uses MOD_NAME_OFFSET macro based on
> host machines bits-per-long, instead of the target archs
> bits-per-long.
>
> This fixes above issue by changing modname-offset based on
> the target archs bitwidth. This is ok because linux kernel
> uses LP64 model on 64bit arch.
Seems simple enough, thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2017-01-02 17:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 15:20 [PATCH perf/core] perf-probe: Fix to get correct modname from elf header Masami Hiramatsu
2017-01-02 17:09 ` Arnaldo Carvalho de Melo [this message]
2017-01-05 7:50 ` [tip:perf/urgent] perf probe: " tip-bot for Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102170940.GD21178@kernel.org \
--to=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox