From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933730AbdABRLS (ORCPT ); Mon, 2 Jan 2017 12:11:18 -0500 Received: from mail.kernel.org ([198.145.29.136]:59808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933272AbdABRJq (ORCPT ); Mon, 2 Jan 2017 12:09:46 -0500 Date: Mon, 2 Jan 2017 14:09:40 -0300 From: Arnaldo Carvalho de Melo To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Peter Zijlstra , Ingo Molnar , Namhyung Kim Subject: Re: [PATCH perf/core] perf-probe: Fix to get correct modname from elf header Message-ID: <20170102170940.GD21178@kernel.org> References: <148337043836.6752.383495516397005695.stgit@devbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148337043836.6752.383495516397005695.stgit@devbox> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 03, 2017 at 12:20:49AM +0900, Masami Hiramatsu escreveu: > Since perf-probe supports cross-arch probe, it is possible to > analyze different arch kernel image which has different > bits-per-long. In that case, it fails to get module name > because perf probe uses MOD_NAME_OFFSET macro based on > host machines bits-per-long, instead of the target archs > bits-per-long. > > This fixes above issue by changing modname-offset based on > the target archs bitwidth. This is ok because linux kernel > uses LP64 model on 64bit arch. Seems simple enough, thanks, applied. - Arnaldo