From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934200AbdABWB1 (ORCPT ); Mon, 2 Jan 2017 17:01:27 -0500 Received: from muru.com ([72.249.23.125]:54270 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752024AbdABWA6 (ORCPT ); Mon, 2 Jan 2017 17:00:58 -0500 Date: Mon, 2 Jan 2017 14:00:54 -0800 From: Tony Lindgren To: Linus Walleij Cc: Gary Bisson , Fabio Estevam , Shawn Guo , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers Message-ID: <20170102220053.GG9325@atomide.com> References: <20170102182022.2047-1-gary.bisson@boundarydevices.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Linus Walleij [170102 13:44]: > On Mon, Jan 2, 2017 at 7:20 PM, Gary Bisson > wrote: > > > This series is a follow-up to Linus suggestion to use the generic helpers > > introduced by Tony [1]. > > > > Mainly I've used the generic functions in pinctrl_ops and pinmux_ops and > > switched to the generic group/function_desc structures instead of the > > imx-specific one that didn't bring anything special. > > Awesome job. Really nice! > > > However I couldn't use the 'add' functions to add elements since the > > parsing is done at probe time in its own way. So I've kept the > > radix_insert functions. This could be modified in the future though. > > Let's see if Tony has some ideas. We already save a bunch of > code by this which is very nice. I attempted a generic iterator in the ti-iodelay.c but so far did not really manage to simplify it at all.. Tony