From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757799AbdACJZU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 3 Jan 2017 04:25:20 -0500
Received: from bombadil.infradead.org ([198.137.202.9]:49332 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757652AbdACJZJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Jan 2017 04:25:09 -0500
Date: Tue, 3 Jan 2017 10:24:59 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: mingo@kernel.org, torvalds@linux-foundation.org,
        catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [RFC PATCH] sched: Remove set_task_state()
Message-ID: <20170103092459.GB3093@worktop>
References: <1483121873-21528-1-git-send-email-dave@stgolabs.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1483121873-21528-1-git-send-email-dave@stgolabs.net>
User-Agent: Mutt/1.5.22.1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 30, 2016 at 10:17:53AM -0800, Davidlohr Bueso wrote:

> -			set_task_state(current, TASK_RUNNING);
> +			set_current_state(TASK_RUNNING);

Obviously good.

> -		set_task_state(tsk, TASK_UNINTERRUPTIBLE);
> +		set_current_state(TASK_UNINTERRUPTIBLE);

Not so much..


So while I fully support this move, should we not first clean up the
code and also remove all the local 'tsk = current' variables such that
all replacements end up being obvious?

In any case, would be good to hear from arm64 folks.