From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934809AbdACI7f (ORCPT ); Tue, 3 Jan 2017 03:59:35 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:55358 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932950AbdACI70 (ORCPT ); Tue, 3 Jan 2017 03:59:26 -0500 Date: Tue, 3 Jan 2017 09:59:18 +0100 From: Boris Brezillon To: Sushaanth Srirangapathi Cc: David Woodhouse , Brian Norris , linux-mtd@lists.infradead.org, linux-omap@vger.kernel.org, Sekhar Nori , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand Message-ID: <20170103095918.7da43be3@bbrezillon> In-Reply-To: <1457428095-2801-1-git-send-email-sushaanth.s@ti.com> References: <1457428095-2801-1-git-send-email-sushaanth.s@ti.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sushaanth, Sorry for the late reply, I'm dequeing old NAND related patches and found this one. Is this patch still needed? On Tue, 8 Mar 2016 14:38:15 +0530 Sushaanth Srirangapathi wrote: > Commit 28c015a9daabe4e ("mtd: davinci-nand: disable subpage write for > keystone-nand") disables subpage write for Keystone SOCs due to hw > issues. > > But subpage writes doesn't work even for DaVinci SOCs due to hw issues. > So set NAND_NO_SUBPAGE_WRITE option for all devices compatible to > this driver. > > I tested this patch using DA850 board. > > Signed-off-by: Sushaanth Srirangapathi > --- > drivers/mtd/nand/davinci_nand.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c > index 8cb821b..466439c 100644 > --- a/drivers/mtd/nand/davinci_nand.c > +++ b/drivers/mtd/nand/davinci_nand.c > @@ -601,11 +601,7 @@ static struct davinci_nand_pdata > of_property_read_bool(pdev->dev.of_node, > "ti,davinci-nand-use-bbt")) > pdata->bbt_options = NAND_BBT_USE_FLASH; > - > - if (of_device_is_compatible(pdev->dev.of_node, > - "ti,keystone-nand")) { > - pdata->options |= NAND_NO_SUBPAGE_WRITE; > - } > + pdata->options |= NAND_NO_SUBPAGE_WRITE; > } > > return dev_get_platdata(&pdev->dev);