* [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand
@ 2016-03-08 9:08 Sushaanth Srirangapathi
2017-01-03 8:59 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Sushaanth Srirangapathi @ 2016-03-08 9:08 UTC (permalink / raw)
To: David Woodhouse, Brian Norris
Cc: Sekhar Nori, linux-omap, linux-mtd, linux-kernel,
Sushaanth Srirangapathi
Commit 28c015a9daabe4e ("mtd: davinci-nand: disable subpage write for
keystone-nand") disables subpage write for Keystone SOCs due to hw
issues.
But subpage writes doesn't work even for DaVinci SOCs due to hw issues.
So set NAND_NO_SUBPAGE_WRITE option for all devices compatible to
this driver.
I tested this patch using DA850 board.
Signed-off-by: Sushaanth Srirangapathi <sushaanth.s@ti.com>
---
drivers/mtd/nand/davinci_nand.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
index 8cb821b..466439c 100644
--- a/drivers/mtd/nand/davinci_nand.c
+++ b/drivers/mtd/nand/davinci_nand.c
@@ -601,11 +601,7 @@ static struct davinci_nand_pdata
of_property_read_bool(pdev->dev.of_node,
"ti,davinci-nand-use-bbt"))
pdata->bbt_options = NAND_BBT_USE_FLASH;
-
- if (of_device_is_compatible(pdev->dev.of_node,
- "ti,keystone-nand")) {
- pdata->options |= NAND_NO_SUBPAGE_WRITE;
- }
+ pdata->options |= NAND_NO_SUBPAGE_WRITE;
}
return dev_get_platdata(&pdev->dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand
2016-03-08 9:08 [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand Sushaanth Srirangapathi
@ 2017-01-03 8:59 ` Boris Brezillon
2017-01-03 11:37 ` Sekhar Nori
0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2017-01-03 8:59 UTC (permalink / raw)
To: Sushaanth Srirangapathi
Cc: David Woodhouse, Brian Norris, linux-mtd, linux-omap, Sekhar Nori,
linux-kernel
Hi Sushaanth,
Sorry for the late reply, I'm dequeing old NAND related patches and
found this one.
Is this patch still needed?
On Tue, 8 Mar 2016 14:38:15 +0530
Sushaanth Srirangapathi <sushaanth.s@ti.com> wrote:
> Commit 28c015a9daabe4e ("mtd: davinci-nand: disable subpage write for
> keystone-nand") disables subpage write for Keystone SOCs due to hw
> issues.
>
> But subpage writes doesn't work even for DaVinci SOCs due to hw issues.
> So set NAND_NO_SUBPAGE_WRITE option for all devices compatible to
> this driver.
>
> I tested this patch using DA850 board.
>
> Signed-off-by: Sushaanth Srirangapathi <sushaanth.s@ti.com>
> ---
> drivers/mtd/nand/davinci_nand.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/nand/davinci_nand.c b/drivers/mtd/nand/davinci_nand.c
> index 8cb821b..466439c 100644
> --- a/drivers/mtd/nand/davinci_nand.c
> +++ b/drivers/mtd/nand/davinci_nand.c
> @@ -601,11 +601,7 @@ static struct davinci_nand_pdata
> of_property_read_bool(pdev->dev.of_node,
> "ti,davinci-nand-use-bbt"))
> pdata->bbt_options = NAND_BBT_USE_FLASH;
> -
> - if (of_device_is_compatible(pdev->dev.of_node,
> - "ti,keystone-nand")) {
> - pdata->options |= NAND_NO_SUBPAGE_WRITE;
> - }
> + pdata->options |= NAND_NO_SUBPAGE_WRITE;
> }
>
> return dev_get_platdata(&pdev->dev);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand
2017-01-03 8:59 ` Boris Brezillon
@ 2017-01-03 11:37 ` Sekhar Nori
2017-01-03 13:13 ` Boris Brezillon
0 siblings, 1 reply; 4+ messages in thread
From: Sekhar Nori @ 2017-01-03 11:37 UTC (permalink / raw)
To: Boris Brezillon
Cc: David Woodhouse, Brian Norris, linux-mtd, linux-omap,
linux-kernel, Cooper Jr., Franklin, Murali Karicheri
Hi Boris,
On Tuesday 03 January 2017 02:29 PM, Boris Brezillon wrote:
> Hi Sushaanth,
Sushaanth is not with TI anymore. You might have received a bounce.
>
> Sorry for the late reply, I'm dequeing old NAND related patches and
> found this one.
>
> Is this patch still needed?
I dont think so. I suspect the real root cause was addressed by Karl in
commit f6d7c1b5598b ("mtd: nand: davinci: Reinitialize the HW ECC
engine in 4bit hwctl")
I just ran mtd_subpagetest on my da850 lcdk board and it passed[1]. If
there are more tests to run to determine if subpage write really works,
let me know too.
I suspect even the original workaround for keystone boards may not be
needed after Karl's patch. I will test and send a patch dropping the
workaround altogether if the tests succeed.
Thanks,
Sekhar
[1]
# modprobe mtd_subpagetest dev=2
=================================================
mtd_subpagetest: MTD device: 2
mtd_subpagetest: MTD device size 536215552, eraseblock size 131072, page size 2048, subpage size 512, count of eraseblocks 4091, pages
per eraseblock 64, OOB size 64
mtd_test: scanning for bad eraseblocks
mtd_test: block 4087 is bad
mtd_test: block 4088 is bad
mtd_test: block 4089 is bad
mtd_test: block 4090 is bad
mtd_test: scanned 4091 eraseblocks, 4 are bad
mtd_subpagetest: writing whole device
mtd_subpagetest: written up to eraseblock 0
mtd_subpagetest: written up to eraseblock 256
mtd_subpagetest: written up to eraseblock 512
mtd_subpagetest: written up to eraseblock 768
mtd_subpagetest: written up to eraseblock 1024
mtd_subpagetest: written up to eraseblock 1280
mtd_subpagetest: written up to eraseblock 1536
mtd_subpagetest: written up to eraseblock 1792
mtd_subpagetest: written up to eraseblock 2048
mtd_subpagetest: written up to eraseblock 2304
mtd_subpagetest: written up to eraseblock 2560
mtd_subpagetest: written up to eraseblock 2816
mtd_subpagetest: written up to eraseblock 3072
mtd_subpagetest: written up to eraseblock 3328
mtd_subpagetest: written up to eraseblock 3584
mtd_subpagetest: written up to eraseblock 3840
mtd_subpagetest: written 4091 eraseblocks
mtd_subpagetest: verifying all eraseblocks
mtd_subpagetest: verified up to eraseblock 0
mtd_subpagetest: verified up to eraseblock 256
mtd_subpagetest: verified up to eraseblock 512
mtd_subpagetest: verified up to eraseblock 768
mtd_subpagetest: verified up to eraseblock 1024
mtd_subpagetest: verified up to eraseblock 1280
mtd_subpagetest: verified up to eraseblock 1536
mtd_subpagetest: verified up to eraseblock 1792
mtd_subpagetest: verified up to eraseblock 2048
mtd_subpagetest: verified up to eraseblock 2304
mtd_subpagetest: verified up to eraseblock 2560
mtd_subpagetest: verified up to eraseblock 2816
mtd_subpagetest: verified up to eraseblock 3072
mtd_subpagetest: verified up to eraseblock 3328
mtd_subpagetest: verified up to eraseblock 3584
mtd_subpagetest: verified up to eraseblock 3840
mtd_subpagetest: verified 4091 eraseblocks
mtd_subpagetest: verifying all eraseblocks for 0xff
mtd_subpagetest: verified up to eraseblock 0
mtd_subpagetest: verified up to eraseblock 256
mtd_subpagetest: verified up to eraseblock 512
mtd_subpagetest: verified up to eraseblock 768
mtd_subpagetest: verified up to eraseblock 1024
mtd_subpagetest: verified up to eraseblock 1280
mtd_subpagetest: verified up to eraseblock 1536
mtd_subpagetest: verified up to eraseblock 1792
mtd_subpagetest: verified up to eraseblock 2048
mtd_subpagetest: verified up to eraseblock 2304
mtd_subpagetest: verified up to eraseblock 2560
mtd_subpagetest: verified up to eraseblock 2816
mtd_subpagetest: verified up to eraseblock 3072
mtd_subpagetest: verified up to eraseblock 3328
mtd_subpagetest: verified up to eraseblock 3584
mtd_subpagetest: verified up to eraseblock 3840
mtd_subpagetest: verified 4091 eraseblocks
mtd_subpagetest: writing whole device
mtd_subpagetest: written up to eraseblock 0
mtd_subpagetest: written up to eraseblock 256
mtd_subpagetest: written up to eraseblock 512
mtd_subpagetest: written up to eraseblock 768
mtd_subpagetest: written up to eraseblock 1024
mtd_subpagetest: written up to eraseblock 1280
mtd_subpagetest: written up to eraseblock 1536
mtd_subpagetest: written up to eraseblock 1792
mtd_subpagetest: written up to eraseblock 2048
mtd_subpagetest: written up to eraseblock 2304
mtd_subpagetest: written up to eraseblock 2560
mtd_subpagetest: written up to eraseblock 2816
mtd_subpagetest: written up to eraseblock 3072
mtd_subpagetest: written up to eraseblock 3328
mtd_subpagetest: written up to eraseblock 3584
mtd_subpagetest: written up to eraseblock 3840
mtd_subpagetest: written 4091 eraseblocks
mtd_subpagetest: verifying all eraseblocks
mtd_subpagetest: verified up to eraseblock 0
mtd_subpagetest: verified up to eraseblock 256
mtd_subpagetest: verified up to eraseblock 512
mtd_subpagetest: verified up to eraseblock 768
mtd_subpagetest: verified up to eraseblock 1024
mtd_subpagetest: verified up to eraseblock 1280
mtd_subpagetest: verified up to eraseblock 1536
mtd_subpagetest: verified up to eraseblock 1792
mtd_subpagetest: verified up to eraseblock 2048
mtd_subpagetest: verified up to eraseblock 2304
mtd_subpagetest: verified up to eraseblock 2560
mtd_subpagetest: verified up to eraseblock 2816
mtd_subpagetest: verified up to eraseblock 3072
mtd_subpagetest: verified up to eraseblock 3328
mtd_subpagetest: verified up to eraseblock 3584
mtd_subpagetest: verified up to eraseblock 3840
mtd_subpagetest: verified 4091 eraseblocks
mtd_subpagetest: verifying all eraseblocks for 0xff
mtd_subpagetest: verified up to eraseblock 0
mtd_subpagetest: verified up to eraseblock 256
mtd_subpagetest: verified up to eraseblock 512
mtd_subpagetest: verified up to eraseblock 768
mtd_subpagetest: verified up to eraseblock 1024
mtd_subpagetest: verified up to eraseblock 1280
mtd_subpagetest: verified up to eraseblock 1536
mtd_subpagetest: verified up to eraseblock 1792
mtd_subpagetest: verified up to eraseblock 2048
mtd_subpagetest: verified up to eraseblock 2304
mtd_subpagetest: verified up to eraseblock 2560
mtd_subpagetest: verified up to eraseblock 2816
mtd_subpagetest: verified up to eraseblock 3072
mtd_subpagetest: verified up to eraseblock 3328
mtd_subpagetest: verified up to eraseblock 3584
mtd_subpagetest: verified up to eraseblock 3840
mtd_subpagetest: verified 4091 eraseblocks
mtd_subpagetest: finished with 0 errors
=================================================
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand
2017-01-03 11:37 ` Sekhar Nori
@ 2017-01-03 13:13 ` Boris Brezillon
0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2017-01-03 13:13 UTC (permalink / raw)
To: Sekhar Nori
Cc: David Woodhouse, Brian Norris, linux-mtd, linux-omap,
linux-kernel, Cooper Jr., Franklin, Murali Karicheri
Hi Sekhar,
On Tue, 3 Jan 2017 17:07:44 +0530
Sekhar Nori <nsekhar@ti.com> wrote:
> Hi Boris,
>
> On Tuesday 03 January 2017 02:29 PM, Boris Brezillon wrote:
> > Hi Sushaanth,
>
> Sushaanth is not with TI anymore. You might have received a bounce.
Indeed.
>
> >
> > Sorry for the late reply, I'm dequeing old NAND related patches and
> > found this one.
> >
> > Is this patch still needed?
>
> I dont think so. I suspect the real root cause was addressed by Karl in
> commit f6d7c1b5598b ("mtd: nand: davinci: Reinitialize the HW ECC
> engine in 4bit hwctl")
Okay, cool. I'll just mark the patch as 'Superseeded' in patchwork.
>
> I just ran mtd_subpagetest on my da850 lcdk board and it passed[1]. If
> there are more tests to run to determine if subpage write really works,
> let me know too.
No, that should be good.
>
> I suspect even the original workaround for keystone boards may not be
> needed after Karl's patch. I will test and send a patch dropping the
> workaround altogether if the tests succeed.
Sounds good.
Thanks,
Boris
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-03 13:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-08 9:08 [PATCH] mtd: davinci-nand: disable subpage write for davinci-nand Sushaanth Srirangapathi
2017-01-03 8:59 ` Boris Brezillon
2017-01-03 11:37 ` Sekhar Nori
2017-01-03 13:13 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox