* [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static
@ 2016-12-23 15:42 Karthik Nayak
2017-01-03 14:05 ` Greg KH
2017-01-13 1:21 ` [lustre-devel] " Dilger, Andreas
0 siblings, 2 replies; 3+ messages in thread
From: Karthik Nayak @ 2016-12-23 15:42 UTC (permalink / raw)
To: linux-kernel, devel
Cc: lustre-devel, kirill.shutemov, liang.zhen, gregkh, jsimmons,
andreas.dilger, oleg.drokin, Karthik Nayak
Since the function brw_inject_one_error() is used only within
brw_test.c, make it static. This was reported as a warning by sparse.
Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
---
drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c b/drivers/staging/lustre/lnet/selftest/brw_test.c
index 67b460f..b9ac34e 100644
--- a/drivers/staging/lustre/lnet/selftest/brw_test.c
+++ b/drivers/staging/lustre/lnet/selftest/brw_test.c
@@ -136,7 +136,7 @@ brw_client_init(struct sfw_test_instance *tsi)
return 0;
}
-int brw_inject_one_error(void)
+static int brw_inject_one_error(void)
{
struct timespec64 ts;
--
2.10.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static
2016-12-23 15:42 [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static Karthik Nayak
@ 2017-01-03 14:05 ` Greg KH
2017-01-13 1:21 ` [lustre-devel] " Dilger, Andreas
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2017-01-03 14:05 UTC (permalink / raw)
To: Karthik Nayak
Cc: linux-kernel, devel, andreas.dilger, liang.zhen, oleg.drokin,
kirill.shutemov, lustre-devel
On Fri, Dec 23, 2016 at 09:12:44PM +0530, Karthik Nayak wrote:
> Since the function brw_inject_one_error() is used only within
> brw_test.c, make it static. This was reported as a warning by sparse.
>
> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
> ---
> drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Someone else sent this same patch before you did, sorry :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [lustre-devel] [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static
2016-12-23 15:42 [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static Karthik Nayak
2017-01-03 14:05 ` Greg KH
@ 2017-01-13 1:21 ` Dilger, Andreas
1 sibling, 0 replies; 3+ messages in thread
From: Dilger, Andreas @ 2017-01-13 1:21 UTC (permalink / raw)
To: Karthik Nayak
Cc: LKML, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
Drokin, Oleg, kirill.shutemov@linux.intel.com,
lustre-devel@lists.lustre.org
On Dec 23, 2016, at 08:42, Karthik Nayak <karthik.188@gmail.com> wrote:
>
> Since the function brw_inject_one_error() is used only within
> brw_test.c, make it static. This was reported as a warning by sparse.
>
> Signed-off-by: Karthik Nayak <Karthik.188@gmail.com>
Reviewed-by: Andreas Dilger <andreas.dilger@intel.com>
> ---
> drivers/staging/lustre/lnet/selftest/brw_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/brw_test.c b/drivers/staging/lustre/lnet/selftest/brw_test.c
> index 67b460f..b9ac34e 100644
> --- a/drivers/staging/lustre/lnet/selftest/brw_test.c
> +++ b/drivers/staging/lustre/lnet/selftest/brw_test.c
> @@ -136,7 +136,7 @@ brw_client_init(struct sfw_test_instance *tsi)
> return 0;
> }
>
> -int brw_inject_one_error(void)
> +static int brw_inject_one_error(void)
> {
> struct timespec64 ts;
>
> --
> 2.10.2
>
> _______________________________________________
> lustre-devel mailing list
> lustre-devel@lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-13 1:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-23 15:42 [PATCH] staging: lustre: selftest: Make brw_inject_one_error() static Karthik Nayak
2017-01-03 14:05 ` Greg KH
2017-01-13 1:21 ` [lustre-devel] " Dilger, Andreas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox