From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965081AbdACO7j (ORCPT <rfc822;w@1wt.eu>);
        Tue, 3 Jan 2017 09:59:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:41058 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935442AbdACO65 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 3 Jan 2017 09:58:57 -0500
Date: Tue, 3 Jan 2017 15:58:54 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
        linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 1/4] perf, tools: Add probing for xed
Message-ID: <20170103145854.GB26251@krava>
References: <20170103090029.17621-1-andi@firstfloor.org>
 <20170103090029.17621-2-andi@firstfloor.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170103090029.17621-2-andi@firstfloor.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 03 Jan 2017 14:58:58 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 03, 2017 at 01:00:26AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Add autoprobing for the xed disassembler library.
> 
> Can be downloaded from https://github.com/intelxed/xed
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
> ---
>  tools/build/Makefile.feature   | 6 ++++--
>  tools/build/feature/Makefile   | 8 ++++++--
>  tools/build/feature/test-all.c | 5 +++++
>  tools/build/feature/test-xed.c | 9 +++++++++
>  tools/perf/Makefile.config     | 5 +++++
>  5 files changed, 29 insertions(+), 4 deletions(-)
>  create mode 100644 tools/build/feature/test-xed.c
> 
> diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature
> index e3fb5ecbdcb6..25183fa39963 100644
> --- a/tools/build/Makefile.feature
> +++ b/tools/build/Makefile.feature
> @@ -63,7 +63,8 @@ FEATURE_TESTS_BASIC :=                  \
>          lzma                            \
>          get_cpuid                       \
>          bpf                             \
> -        sdt
> +	sdt				\
> +	xed
>  
>  # FEATURE_TESTS_BASIC + FEATURE_TESTS_EXTRA is the complete list
>  # of all feature tests
> @@ -105,7 +106,8 @@ FEATURE_DISPLAY ?=              \
>           zlib                   \
>           lzma                   \
>           get_cpuid              \
> -         bpf
> +	 bpf			\
> +	 xed

please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed
package yet, just the sources, so the "xed: OFF" build message would
bother almost everyone probably for long time..

thanks,
jirka