From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935395AbdACPg3 (ORCPT ); Tue, 3 Jan 2017 10:36:29 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37148 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758724AbdACPgV (ORCPT ); Tue, 3 Jan 2017 10:36:21 -0500 Date: Tue, 3 Jan 2017 15:30:50 +0000 From: Lee Jones To: Nicolae Rosia Cc: Mark Brown , Rob Herring , Mark Rutland , Tony Lindgren , Liam Girdwood , Paul Gortmaker , Graeme Gregory , Baruch Siach , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/5] mfd: twl: remove useless header Message-ID: <20170103153050.GH2977@dell> References: <20161126181326.14951-1-Nicolae_Rosia@mentor.com> <20161126181326.14951-3-Nicolae_Rosia@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161126181326.14951-3-Nicolae_Rosia@mentor.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Nov 2016, Nicolae Rosia wrote: > This header has one user, twl-core.c . > Remove it before it gets more users. The header is not useless. It prevents us from having to place external prototypes into C files. > Signed-off-by: Nicolae Rosia > --- > drivers/mfd/twl-core.c | 8 ++++++-- > drivers/mfd/twl-core.h | 10 ---------- > drivers/mfd/twl4030-irq.c | 2 -- > drivers/mfd/twl6030-irq.c | 2 -- > 4 files changed, 6 insertions(+), 16 deletions(-) > delete mode 100644 drivers/mfd/twl-core.h > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 48b0668..e16084e 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -52,8 +52,6 @@ > /* Register descriptions for audio */ > #include > > -#include "twl-core.h" > - > /* > * The TWL4030 "Triton 2" is one of a family of a multi-function "Power > * Management and System Companion Device" chips originally designed for > @@ -150,6 +148,12 @@ > > /*----------------------------------------------------------------------*/ > > +int twl6030_init_irq(struct device *dev, int irq_num); > +int twl6030_exit_irq(void); > +int twl4030_init_irq(struct device *dev, int irq_num); > +int twl4030_exit_irq(void); > +int twl4030_init_chip_irq(const char *chip); > + > /* Structure for each TWL4030/TWL6030 Slave */ > struct twl_client { > struct i2c_client *client; > diff --git a/drivers/mfd/twl-core.h b/drivers/mfd/twl-core.h > deleted file mode 100644 > index 6ff99dc..0000000 > --- a/drivers/mfd/twl-core.h > +++ /dev/null > @@ -1,10 +0,0 @@ > -#ifndef __TWL_CORE_H__ > -#define __TWL_CORE_H__ > - > -extern int twl6030_init_irq(struct device *dev, int irq_num); > -extern int twl6030_exit_irq(void); > -extern int twl4030_init_irq(struct device *dev, int irq_num); > -extern int twl4030_exit_irq(void); > -extern int twl4030_init_chip_irq(const char *chip); > - > -#endif /* __TWL_CORE_H__ */ > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c > index b46c0cf..000c231 100644 > --- a/drivers/mfd/twl4030-irq.c > +++ b/drivers/mfd/twl4030-irq.c > @@ -35,8 +35,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL4030 IRQ handling has two stages in hardware, and thus in software. > * The Primary Interrupt Handler (PIH) stage exposes status bits saying > diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c > index 5357450..63eca76 100644 > --- a/drivers/mfd/twl6030-irq.c > +++ b/drivers/mfd/twl6030-irq.c > @@ -42,8 +42,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL6030 (unlike its predecessors, which had two level interrupt handling) > * three interrupt registers INT_STS_A, INT_STS_B and INT_STS_C. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog