From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760633AbdACSj7 (ORCPT ); Tue, 3 Jan 2017 13:39:59 -0500 Received: from mail.kernel.org ([198.145.29.136]:58900 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760610AbdACSjw (ORCPT ); Tue, 3 Jan 2017 13:39:52 -0500 Date: Tue, 3 Jan 2017 15:39:46 -0300 From: Arnaldo Carvalho de Melo To: Andi Kleen Cc: Jiri Olsa , Andi Kleen , jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] perf, tools: Add probing for xed Message-ID: <20170103183946.GK27864@kernel.org> References: <20170103090029.17621-1-andi@firstfloor.org> <20170103090029.17621-2-andi@firstfloor.org> <20170103145854.GB26251@krava> <20170103151106.GX8388@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103151106.GX8388@tassilo.jf.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu: > > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed > > package yet, just the sources, so the "xed: OFF" build message would > > bother almost everyone probably for long time.. > > It should be eventually packaged. How would people know they are missing > it without displaying it? I think it has to, otherwise most people will > miss out on the feature. Silent failure is bad. Right, you have a point, we should have some warning to the user for when features are not being automatically probed for, i.e. extra features may be enabled using special command line settings, read the docs to see how. - Arnaldo