From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760604AbdACTsh (ORCPT ); Tue, 3 Jan 2017 14:48:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53648 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758515AbdACTs0 (ORCPT ); Tue, 3 Jan 2017 14:48:26 -0500 Date: Tue, 3 Jan 2017 20:48:22 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Andi Kleen , Andi Kleen , jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] perf, tools: Add probing for xed Message-ID: <20170103194822.GC8826@krava> References: <20170103090029.17621-1-andi@firstfloor.org> <20170103090029.17621-2-andi@firstfloor.org> <20170103145854.GB26251@krava> <20170103151106.GX8388@tassilo.jf.intel.com> <20170103183946.GK27864@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103183946.GK27864@kernel.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 03 Jan 2017 19:48:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 03:39:46PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu: > > > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed > > > package yet, just the sources, so the "xed: OFF" build message would > > > bother almost everyone probably for long time.. > > > > It should be eventually packaged. How would people know they are missing > > it without displaying it? I think it has to, otherwise most people will > > miss out on the feature. Silent failure is bad. make VF=1 will show it > Right, you have a point, we should have some warning to the user for > when features are not being automatically probed for, i.e. extra > features may be enabled using special command line settings, read the > docs to see how. we could print out one line saying we did not detect all the features jirka