From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935096AbdADKPT (ORCPT ); Wed, 4 Jan 2017 05:15:19 -0500 Received: from merlin.infradead.org ([205.233.59.134]:38186 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753331AbdADKPR (ORCPT ); Wed, 4 Jan 2017 05:15:17 -0500 Date: Wed, 4 Jan 2017 11:15:07 +0100 From: Peter Zijlstra To: Will Deacon Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, kim.phillips@arm.com, alex.bennee@linaro.org, christoffer.dall@linaro.org, tglx@linutronix.de, alexander.shishkin@linux.intel.com, robh@kernel.org, suzuki.poulose@arm.com, pawel.moll@arm.com, mathieu.poirier@linaro.org, mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 06/10] perf/core: Export AUX buffer helpers to modules Message-ID: <20170104101507.GG25813@worktop.programming.kicks-ass.net> References: <1483467027-14547-1-git-send-email-will.deacon@arm.com> <1483467027-14547-7-git-send-email-will.deacon@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483467027-14547-7-git-send-email-will.deacon@arm.com> User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 06:10:23PM +0000, Will Deacon wrote: > +EXPORT_SYMBOL(perf_aux_output_begin); > +EXPORT_SYMBOL(perf_aux_output_end); > +EXPORT_SYMBOL(perf_aux_output_skip); > +EXPORT_SYMBOL(perf_get_aux); $ git grep EXPORT kernel/events/ kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_disable); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_enable); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_addr_filters_sync); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_refresh); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_release_kernel); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_read_value); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_register_guest_info_callbacks); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_unregister_guest_info_callbacks); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_swevent_get_recursion_context); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_trace_run_bpf_submit); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_tp_event); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_pmu_register); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_pmu_unregister); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_create_kernel_counter); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_pmu_migrate_context); kernel/events/core.c:EXPORT_SYMBOL_GPL(perf_event_sysfs_show); kernel/events/hw_breakpoint.c:EXPORT_SYMBOL_GPL(register_user_hw_breakpoint); kernel/events/hw_breakpoint.c:EXPORT_SYMBOL_GPL(modify_user_hw_breakpoint); kernel/events/hw_breakpoint.c:EXPORT_SYMBOL_GPL(unregister_hw_breakpoint); kernel/events/hw_breakpoint.c:EXPORT_SYMBOL_GPL(register_wide_hw_breakpoint); kernel/events/hw_breakpoint.c:EXPORT_SYMBOL_GPL(unregister_wide_hw_breakpoint); kernel/events/uprobes.c:EXPORT_SYMBOL_GPL(uprobe_register); kernel/events/uprobes.c:EXPORT_SYMBOL_GPL(uprobe_unregister); I see a distinct difference here... :-)