From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
bp@alien8.de, peterz@infradead.org, mingo@redhat.com
Subject: Re: [PATCH V6 2/7] perf/amd/iommu: Modify functions to query max banks and counters
Date: Wed, 4 Jan 2017 15:48:53 +0100 [thread overview]
Message-ID: <20170104144853.GE10632@8bytes.org> (raw)
In-Reply-To: <1482500330-5606-3-git-send-email-Suravee.Suthikulpanit@amd.com>
On Fri, Dec 23, 2016 at 08:38:45PM +0700, Suravee Suthikulpanit wrote:
> --- a/arch/x86/events/amd/iommu.h
> +++ b/arch/x86/events/amd/iommu.h
> @@ -24,15 +24,12 @@
> #define PC_MAX_SPEC_BNKS 64
> #define PC_MAX_SPEC_CNTRS 16
>
> -/* iommu pc reg masks*/
> -#define IOMMU_BASE_DEVID 0x0000
> -
> /* amd_iommu_init.c external support functions */
> extern bool amd_iommu_pc_supported(void);
>
> -extern u8 amd_iommu_pc_get_max_banks(u16 devid);
> +extern u8 amd_iommu_pc_get_max_banks(uint devid);
>
> -extern u8 amd_iommu_pc_get_max_counters(u16 devid);
> +extern u8 amd_iommu_pc_get_max_counters(uint devid);
The parameters are now iommu-indexes and not device-ids anymore. You
should reflect that in the prototypes here too.
> diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h
> index 7eb60c1..1f10b3f 100644
> --- a/drivers/iommu/amd_iommu_proto.h
> +++ b/drivers/iommu/amd_iommu_proto.h
> @@ -58,8 +58,8 @@ extern int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, int pasid,
>
> /* IOMMU Performance Counter functions */
> extern bool amd_iommu_pc_supported(void);
> -extern u8 amd_iommu_pc_get_max_banks(u16 devid);
> -extern u8 amd_iommu_pc_get_max_counters(u16 devid);
> +extern u8 amd_iommu_pc_get_max_banks(uint devid);
> +extern u8 amd_iommu_pc_get_max_counters(uint devid);
Same here, and why do you need to declare the prototypes in two
different header files?
next prev parent reply other threads:[~2017-01-04 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 13:38 [PATCH V6 0/7] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 1/7] perf/amd/iommu: Misc fix up perf_iommu_read Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 2/7] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2017-01-04 14:48 ` Joerg Roedel [this message]
2017-01-09 10:48 ` Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 3/7] perf/amd/iommu: Modify IOMMU API to allow specifying IOMMU index Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 4/7] perf/amd/iommu: Declare pr_fmt and remove unnecessary pr_debug Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 5/7] perf/amd/iommu: Clean up perf_iommu_enable_event Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 6/7] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2016-12-23 13:38 ` [PATCH V6 7/7] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104144853.GE10632@8bytes.org \
--to=joro@8bytes.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=bp@alien8.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox