From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759037AbdADOtz (ORCPT ); Wed, 4 Jan 2017 09:49:55 -0500 Received: from 8bytes.org ([81.169.241.247]:43790 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759198AbdADOsp (ORCPT ); Wed, 4 Jan 2017 09:48:45 -0500 Date: Wed, 4 Jan 2017 15:48:53 +0100 From: Joerg Roedel To: Suravee Suthikulpanit Cc: linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, bp@alien8.de, peterz@infradead.org, mingo@redhat.com Subject: Re: [PATCH V6 2/7] perf/amd/iommu: Modify functions to query max banks and counters Message-ID: <20170104144853.GE10632@8bytes.org> References: <1482500330-5606-1-git-send-email-Suravee.Suthikulpanit@amd.com> <1482500330-5606-3-git-send-email-Suravee.Suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1482500330-5606-3-git-send-email-Suravee.Suthikulpanit@amd.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 23, 2016 at 08:38:45PM +0700, Suravee Suthikulpanit wrote: > --- a/arch/x86/events/amd/iommu.h > +++ b/arch/x86/events/amd/iommu.h > @@ -24,15 +24,12 @@ > #define PC_MAX_SPEC_BNKS 64 > #define PC_MAX_SPEC_CNTRS 16 > > -/* iommu pc reg masks*/ > -#define IOMMU_BASE_DEVID 0x0000 > - > /* amd_iommu_init.c external support functions */ > extern bool amd_iommu_pc_supported(void); > > -extern u8 amd_iommu_pc_get_max_banks(u16 devid); > +extern u8 amd_iommu_pc_get_max_banks(uint devid); > > -extern u8 amd_iommu_pc_get_max_counters(u16 devid); > +extern u8 amd_iommu_pc_get_max_counters(uint devid); The parameters are now iommu-indexes and not device-ids anymore. You should reflect that in the prototypes here too. > diff --git a/drivers/iommu/amd_iommu_proto.h b/drivers/iommu/amd_iommu_proto.h > index 7eb60c1..1f10b3f 100644 > --- a/drivers/iommu/amd_iommu_proto.h > +++ b/drivers/iommu/amd_iommu_proto.h > @@ -58,8 +58,8 @@ extern int amd_iommu_domain_set_gcr3(struct iommu_domain *dom, int pasid, > > /* IOMMU Performance Counter functions */ > extern bool amd_iommu_pc_supported(void); > -extern u8 amd_iommu_pc_get_max_banks(u16 devid); > -extern u8 amd_iommu_pc_get_max_counters(u16 devid); > +extern u8 amd_iommu_pc_get_max_banks(uint devid); > +extern u8 amd_iommu_pc_get_max_counters(uint devid); Same here, and why do you need to declare the prototypes in two different header files?