From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758222AbdADP52 (ORCPT ); Wed, 4 Jan 2017 10:57:28 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:37929 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754414AbdADP5Z (ORCPT ); Wed, 4 Jan 2017 10:57:25 -0500 Date: Wed, 4 Jan 2017 16:01:07 +0000 From: Lee Jones To: Rob Herring Cc: patrice.chotard@st.com, jassisinghbrar@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, devicetree@vger.kernel.org Subject: Re: [PATCH] mailbox: sti: Fix mbox-names copy and paste error Message-ID: <20170104160107.GD24225@dell> References: <20170104120527.24806-1-lee.jones@linaro.org> <20170104145732.7yiqbi7rf7m6lem4@rob-hp-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170104145732.7yiqbi7rf7m6lem4@rob-hp-laptop> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Jan 2017, Rob Herring wrote: > On Wed, Jan 04, 2017 at 12:05:27PM +0000, Lee Jones wrote: > > Due to an over-sight, mbox-names has become mbox-name in some instances. > > > > Let's put it right. > > > > Signed-off-by: Lee Jones > > --- > > Documentation/devicetree/bindings/mailbox/sti-mailbox.txt | 4 ++-- > > arch/arm/boot/dts/stih407-family.dtsi | 8 ++++---- > > drivers/mailbox/mailbox-sti.c | 2 +- > > 3 files changed, 7 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > index 351f612..648d176 100644 > > --- a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > @@ -9,7 +9,7 @@ Controller > > Required properties: > > - compatible : Should be "st,stih407-mailbox" > > - reg : Offset and length of the device's register set > > -- mbox-name : Name of the mailbox > > +- mbox-names : Name of the mailbox > > It's worse than this. mbox-names is for the mailbox client side. Ah yes, of course. False alarm. Let's just leave it as it is. ;) I'll reply to the reporter directly. > This should just be dropped. Plus, *-names is pointless when there > is only 1 element. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog