From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031409AbdADQHJ (ORCPT ); Wed, 4 Jan 2017 11:07:09 -0500 Received: from mail-wj0-f176.google.com ([209.85.210.176]:34711 "EHLO mail-wj0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936538AbdADQHF (ORCPT ); Wed, 4 Jan 2017 11:07:05 -0500 Date: Wed, 4 Jan 2017 16:04:06 +0000 From: Lee Jones To: Geert Uytterhoeven Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , kernel@stlinux.com, Maxime Coquelin , Jassi Brar , "devicetree@vger.kernel.org" Subject: Re: mbox-name vs. mbox-names (was: Re: [PATCH v4 1/5] mailbox: dt: Supply bindings for ST's Mailbox IP) Message-ID: <20170104160406.GE24225@dell> References: <20161024084107.GD14477@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161024084107.GD14477@dell> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Oct 2016, Lee Jones wrote: > On Fri, 21 Oct 2016, Geert Uytterhoeven wrote: > > > On Fri, Oct 16, 2015 at 9:21 AM, Lee Jones wrote: > > > Signed-off-by: Lee Jones > > > --- > > > .../devicetree/bindings/mailbox/sti-mailbox.txt | 51 ++++++++++++++++++++++ > > > 1 file changed, 51 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > > > > > diff --git a/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > > new file mode 100644 > > > index 0000000..b61eec9 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/mailbox/sti-mailbox.txt > > > @@ -0,0 +1,51 @@ > > > +ST Microelectronics Mailbox Driver > > > + > > > +Each ST Mailbox IP currently consists of 4 instances of 32 channels. Messages > > > +are passed between Application and Remote processors using shared memory. > > > + > > > +Controller > > > +---------- > > > + > > > +Required properties: > > > +- compatible : Should be "st,stih407-mailbox" > > > +- reg : Offset and length of the device's register set > > > +- mbox-name : Name of the mailbox > > > > All other mailbox drivers use "mbox-names". Oops, it's in v4.9-rc1... > > > > Can we still fix that? > > So long as all the fixes; changes to the driver and DT are merged in a > single kernel release, we can change it. Scrap that, change of plan. Actually current code is correct. mbox-name does not have the same functionality as mbox-names. mbox-names is a client-side property used to request channels, where as mbox-name is used to provide a better user-readable name other than mailbox{0..x}. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog