From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936536AbdADQHC (ORCPT ); Wed, 4 Jan 2017 11:07:02 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33428 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936516AbdADQG6 (ORCPT ); Wed, 4 Jan 2017 11:06:58 -0500 Date: Wed, 4 Jan 2017 17:06:54 +0100 From: Jiri Olsa To: Sudeep Holla Cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Jiri Olsa Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is disabled Message-ID: <20170104160654.GA11619@krava> References: <1483537960-14499-1-git-send-email-sudeep.holla@arm.com> <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483545363-11393-1-git-send-email-sudeep.holla@arm.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Wed, 04 Jan 2017 16:06:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote: > When libelf is disabled in the configuration, we get the following > linker error: > LINK libperf-jvmti.so > ld: cannot find -lelf > Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed > > Jiri pointed out that both librt and libelf are not really required. So > this patch fixes the linker error by getting rid of unwanted libraries > in the linker stage. > > Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build") hum, AFAICS it linked -lelf and -lrt even before right? ;-) jirka