From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1761202AbdADRUT (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 12:20:19 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33350 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753580AbdADRT6 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 12:19:58 -0500
Date: Wed, 4 Jan 2017 18:19:55 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v2] tools: perf: fix linker error when libelf config is
 disabled
Message-ID: <20170104171955.GA21024@krava>
References: <1483537960-14499-1-git-send-email-sudeep.holla@arm.com>
 <1483545363-11393-1-git-send-email-sudeep.holla@arm.com>
 <20170104160654.GA11619@krava>
 <a3c0a2f9-9948-6ed5-f253-0673dd0e8358@arm.com>
 <1f976b40-608e-412c-910c-6b0e078a8ae0@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1f976b40-608e-412c-910c-6b0e078a8ae0@arm.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Wed, 04 Jan 2017 17:19:58 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 04, 2017 at 04:18:10PM +0000, Sudeep Holla wrote:
> 
> 
> On 04/01/17 16:08, Sudeep Holla wrote:
> > 
> > 
> > On 04/01/17 16:06, Jiri Olsa wrote:
> >> On Wed, Jan 04, 2017 at 03:56:03PM +0000, Sudeep Holla wrote:
> >>> When libelf is disabled in the configuration, we get the following
> >>> linker error:
> >>>   LINK     libperf-jvmti.so
> >>>   ld: cannot find -lelf
> >>>   Makefile.perf:515: recipe for target 'libperf-jvmti.so' failed
> >>>
> >>> Jiri pointed out that both librt and libelf are not really required. So
> >>> this patch fixes the linker error by getting rid of unwanted libraries
> >>> in the linker stage.
> >>>
> >>> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
> >>
> >> hum, AFAICS it linked -lelf and -lrt even before right? ;-)
> >>
> > 
> > Yes, sorry I forgot to remove that and trace it back the actual commit.
> > 
> 
> Having looked at it again, it looks new additions in the above commit.
> It may be a copied from somewhere else but I can't trace it back :(.
> I need your help if you want to get rid of that ;)

I think it's this one:
  209045adc2bb perf tools: add JVMTI agent library

jirka