From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761079AbdADVWe (ORCPT ); Wed, 4 Jan 2017 16:22:34 -0500 Received: from mail.kernel.org ([198.145.29.136]:51334 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760917AbdADVUx (ORCPT ); Wed, 4 Jan 2017 16:20:53 -0500 Date: Wed, 4 Jan 2017 22:20:47 +0100 From: Sebastian Reichel To: Linus Walleij Cc: Dmitry Eremin-Solenikov , linux-kernel@vger.kernel.org, Lars-Peter Clausen , David Woodhouse , Heiko Stuebner Subject: Re: [PATCH RESEND] power: gpio_charger: switch to using GPIO descriptors Message-ID: <20170104212046.egsccncbvaidioss@earth> References: <20161226201855.25298-1-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zg76ofdzumhohqax" Content-Disposition: inline In-Reply-To: <20161226201855.25298-1-linus.walleij@linaro.org> User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zg76ofdzumhohqax Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Linus, On Mon, Dec 26, 2016 at 09:18:55PM +0100, Linus Walleij wrote: > The GPIO charger is using a mix of the legacy GPIO interface > and which is not the modern way to use GPIOs. >=20 > Refactor like this: >=20 > - Use a GPIO descriptor for the GPIO line used to monitor the > charger. > - Fetch the descriptor with devm_gpiod_get() as the first > method. > - If this fails and we are *not* using device tree, then > start looking to see if we can use platform data instead. > - After looking up and requesting a GPIO number with the > legacy API, convert it to a descriptor. >=20 > This way we can later isolate and drop the legacy code as > more platforms move over to using descriptors. >=20 > Cc: Dmitry Eremin-Solenikov > Cc: Heiko Stuebner > Cc: Lars-Peter Clausen > Signed-off-by: Linus Walleij Thanks for your patch. I have queued it into power-supply's for-next branch: https://git.kernel.org/cgit/linux/kernel/git/sre/linux-power-supply.git/log= /?h=3Dfor-next -- Sebastian --zg76ofdzumhohqax Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlhtZy4ACgkQ2O7X88g7 +prPbg//Z8q/Ly/Eqqar4ig99oaI3scpOkdfvwo5RJ37/bBSrOFnYgrmX4t8QcPS FQpzMzd5q3tWj7uWM492iIoGzmFesty3miZFI012QeIpY3lqSiYfK9Wb9xQHZ0AC Giy56kJ+6xgFh/geKljzURFEI0UjFWkvZovkLzG4NACj2ggs/oqnUwYWZSuFgz7y r5WRy0S+B42kgTv9fbkPAa1Gfh+TSScdFMvxRP6apFSOm4SjWu+jJ/l3z/J92D3Z UB2RoXRjfBSWoI6RSR9zul8CIqK4JmSQPHSatNVpDCLBZRh2G07IcmFXPAHiCeQ9 v5JHB/dlr5fBM42bXqiI7/oBzh/Wk0JHE2lxyeED2EeFfcJVYauMi5G+6NpyukPa DKNC/+K2maGS2y0kFGLLGkAlKTvagBNQsUxwFVqL4mmr444D8NjF0cNbpXEyor96 /9A9MeJbaQ9vYX1csHjX4sQfPgjXXR/LvHQOp4HBzbvUIolqf3PPqwFrS1aZZrI7 Z+7kjeirBYqYXRZoRMVdfIScDBGSj3CJdGWne3EY1vLP/pTYaE/MYh38vs50fppP DU7MJGOEtIWtuB/0epxQvxEJtNVZD45Rq7Ku72bdfjlR1YNWmB+98UbZeJf3Pp8K WFBJUGT/tshKP7GQOZeVVSj8mHYb2aimWpxaaVoKd0m9L0VgODY= =sWKL -----END PGP SIGNATURE----- --zg76ofdzumhohqax--