From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030510AbdAEFl0 (ORCPT ); Thu, 5 Jan 2017 00:41:26 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:53206 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935207AbdAEFlY (ORCPT ); Thu, 5 Jan 2017 00:41:24 -0500 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 165.244.249.26 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Thu, 5 Jan 2017 14:41:19 +0900 From: Minchan Kim To: Michal Hocko CC: Andrew Morton , Mel Gorman , Johannes Weiner , Vlastimil Babka , Hillf Danton , , LKML Subject: Re: [PATCH 2/7] mm, vmscan: add active list aging tracepoint Message-ID: <20170105054119.GB24371@bbox> References: <20170104101942.4860-1-mhocko@kernel.org> <20170104101942.4860-3-mhocko@kernel.org> <20170104135244.GJ25453@dhcp22.suse.cz> MIME-Version: 1.0 In-Reply-To: <20170104135244.GJ25453@dhcp22.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/01/05 14:41:21, Serialize by Router on LGEKRMHUB01/LGE/LG Group(Release 8.5.3FP6|November 21, 2013) at 2017/01/05 14:41:21, Serialize complete at 2017/01/05 14:41:21 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2017 at 02:52:47PM +0100, Michal Hocko wrote: > With fixed triggered by Vlastimil it should be like this. > --- > From b3a1480b54bf10924a9cd09c6d8b274fc81ca4ad Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Tue, 27 Dec 2016 13:18:20 +0100 > Subject: [PATCH] mm, vmscan: add active list aging tracepoint > > Our reclaim process has several tracepoints to tell us more about how > things are progressing. We are, however, missing a tracepoint to track > active list aging. Introduce mm_vmscan_lru_shrink_active which reports > the number of > - nr_taken is number of isolated pages from the active list > - nr_referenced pages which tells us that we are hitting referenced > pages which are deactivated. If this is a large part of the > reported nr_deactivated pages then we might be hitting into > the active list too early because they might be still part of > the working set. This might help to debug performance issues. > - nr_active pages which tells us how many pages are kept on the > active list - mostly exec file backed pages. A high number can > indicate that we might be trashing on executables. > > Changes since v1 > - report nr_taken pages as per Minchan > - report nr_activated as per Minchan > - do not report nr_freed pages because that would add a tiny overhead to > free_hot_cold_page_list which is a hot path > - do not report nr_unevictable because we can report this number via a > different and more generic tracepoint in putback_lru_page > - fix move_active_pages_to_lru to report proper page count when we hit > into large pages > - drop nr_scanned because this can be obtained from > trace_mm_vmscan_lru_isolate as per Minchan > > Acked-by: Hillf Danton > Acked-by: Mel Gorman > Signed-off-by: Michal Hocko Acked-by: Minchan Kim Thanks.