From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033205AbdAEIYr (ORCPT ); Thu, 5 Jan 2017 03:24:47 -0500 Received: from mail-wj0-f196.google.com ([209.85.210.196]:36637 "EHLO mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757444AbdAEIX2 (ORCPT ); Thu, 5 Jan 2017 03:23:28 -0500 Date: Thu, 5 Jan 2017 09:23:24 +0100 From: Ingo Molnar To: Pan Xinhui Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, longman@redhat.com Subject: Re: [PATCH] locking/pvqspinlock: Wait early if vcpu is preempted Message-ID: <20170105082324.GF2098@gmail.com> References: <1481049850-42610-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481049850-42610-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pan Xinhui wrote: > If prev node is not in runnig state or its cpu is preempted, we need > wait early in pv_wait_node. After commit "sched/core: Introduce the > vcpu_is_preempted(cpu) interface" kernel has knowledge of one vcpu is > running or not. So lets use it. That's not how we reference upstream commits. I had to search the git log the hard way to figure out that it's commit d9345c65eb79 ... Also, once you look at that commit you'll see how sloppy the capitalization in your changelog is. I fixed that up for all the original commits in the hope of you learning from those mistakes - but that was last year and the experiment failed. Thanks, Ingo