public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Darren Hart" <dvhart@infradead.org>,
	"Platform Driver" <platform-driver-x86@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Michał Kępień" <kernel@kempniu.pl>,
	"Pali Rohár" <pali.rohar@gmail.com>
Subject: Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
Date: Thu, 5 Jan 2017 09:12:57 +0100	[thread overview]
Message-ID: <20170105091257.54e4b52d@endymion> (raw)
In-Reply-To: <CAHp75VfDWqba5igt48Kqtju7BdubPCaiTp+ixZ5+wZa3RgF5Jg@mail.gmail.com>

Hi Andy,

Thanks for the review.

On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
> 
> Please, use prefix "platform/x86: ".
> Perhaps, use just "dell_smbios: " as second one.

OK, will change.

> >  config DELL_SMBIOS
> > -       tristate "Dell SMBIOS Support"
> > -       depends on DCDBAS
> > +       tristate
> > +       select DCDBAS
> 
> >         default n
> 
> Do we need this one?

Probably not. "n" being the default default, I guess the 844
occurrences of "default n" in the Kconfig tree are pointless ;-)

I'll post v3 of the patch in a minute.

-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2017-01-05  8:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 12:59 [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios Jean Delvare
2017-01-04 13:14 ` Andy Shevchenko
2017-01-05  8:12   ` Jean Delvare [this message]
2017-01-05  8:59 ` Pali Rohár
2017-01-05  9:09   ` Jean Delvare
2017-01-05  9:10     ` Pali Rohár
2017-01-05 21:12       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170105091257.54e4b52d@endymion \
    --to=jdelvare@suse.de \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=kernel@kempniu.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox