From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S968592AbdAEIPV (ORCPT <rfc822;w@1wt.eu>);
        Thu, 5 Jan 2017 03:15:21 -0500
Received: from mx2.suse.de ([195.135.220.15]:50278 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S935525AbdAEIN7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 5 Jan 2017 03:13:59 -0500
Date: Thu, 5 Jan 2017 09:12:57 +0100
From: Jean Delvare <jdelvare@suse.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?TWljaGHFgiBLxJlwaWXFhA==?= <kernel@kempniu.pl>,
        Pali =?UTF-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
Subject: Re: [PATCH v2] dell-wmi, dell-laptop: hide dell-smbios
Message-ID: <20170105091257.54e4b52d@endymion>
In-Reply-To: <CAHp75VfDWqba5igt48Kqtju7BdubPCaiTp+ixZ5+wZa3RgF5Jg@mail.gmail.com>
References: <20170104135917.43eedcc0@endymion>
        <CAHp75VfDWqba5igt48Kqtju7BdubPCaiTp+ixZ5+wZa3RgF5Jg@mail.gmail.com>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.31; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy,

Thanks for the review.

On Wed, 4 Jan 2017 15:14:10 +0200, Andy Shevchenko wrote:
> On Wed, Jan 4, 2017 at 2:59 PM, Jean Delvare <jdelvare@suse.de> wrote:
> > Dell-smbios is a helper module, it serves no purpose on its own, so
> > do not present it as an option to the user. Instead, select it
> > automatically whenever a driver which needs it is selected.
> >
> 
> Please, use prefix "platform/x86: ".
> Perhaps, use just "dell_smbios: " as second one.

OK, will change.

> >  config DELL_SMBIOS
> > -       tristate "Dell SMBIOS Support"
> > -       depends on DCDBAS
> > +       tristate
> > +       select DCDBAS
> 
> >         default n
> 
> Do we need this one?

Probably not. "n" being the default default, I guess the 844
occurrences of "default n" in the Kconfig tree are pointless ;-)

I'll post v3 of the patch in a minute.

-- 
Jean Delvare
SUSE L3 Support