Re: [PATCH v4 07/11] pwm: imx: Provide atomic PWM support for i.MX PWMv2

Andy Shevchenko
2017-01-05T21:24:04Z

On Thu, Jan 5, 2017 at 11:19 AM, Boris Brezillon
<boris.brezillon@free-electrons.com> wrote:
> On Thu, 5 Jan 2017 10:03:47 +0100
> Lukasz Majewski <lukma@denx.de> wrote:
>> > /*
>> > * Wait for a free FIFO slot if the PWM is already
>> > enabled, and
>> > * flush the FIFO if the PWM was disabled and is
>> > about to be
>> > * enabled.
>> > */

>> > if (cstate.enabled) {

if (pwm_is_enabled()) ?

I think it's better to do whatever API provides to be less error prone.

>> > imx_pwm_wait_fifo_slot(chip, pwm);
>> > } else {
>> > ret = clk_prepare_enable(imx->clk_per);
>> > if (ret)
>> > return ret;

>> if (state.enabled && !cstate.enabled)
>> clk_preapre_enable();
>
> Yep, and that's correct.

!pwm_is_enabled() ?

--
With Best Regards,
Andy Shevchenko