From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762606AbdAEMGj (ORCPT ); Thu, 5 Jan 2017 07:06:39 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:42558 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbdAEMGc (ORCPT ); Thu, 5 Jan 2017 07:06:32 -0500 Date: Thu, 5 Jan 2017 13:05:23 +0100 From: Greg KH To: Arvind Yadav Cc: devel@driverdev.osuosl.org, isdn@linux-pingi.de, linux-kernel@vger.kernel.org, arnd@arndb.de Subject: Re: [v1] i4l: act2000: act2000:- Do not use 'asm/io.h' directly, use 'linux/io.h'. Message-ID: <20170105120523.GA23872@kroah.com> References: <1483612764-29543-1-git-send-email-arvind.yadav.cs@gmail.com> <20170105114617.GB8859@kroah.com> <54dd4d9a-7561-8c8a-bc36-2e082fe88725@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54dd4d9a-7561-8c8a-bc36-2e082fe88725@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 05:25:05PM +0530, Arvind Yadav wrote: > Please find my comment below. Where? What happened to your email quoting? > Thanks > -Arvind > > On Thursday 05 January 2017 05:16 PM, Greg KH wrote: > > On Thu, Jan 05, 2017 at 04:09:24PM +0530, Arvind Yadav wrote: > > > Make uniform definition of ioremap, ioremap_wc, ioremap_wt and > > > ioremap_cache, tree-wide. > > That doesn't make much sense, and doesn't match the subject: or the > > patch itself. > > -- Please refer the commit which is already in main-lined. > > commit 2584cf83578c26db144730ef498f4070f82ee3ea Ah, here it is, please quote stuff correctly. If you are referring to something else, great, then say so in the commit itself. Every commit should be self-explanatory, how am I supposed to know this. And this text still doesn't make sense to me, please fix. > > And what is with the "[v1]"? > > ---V1 is stands for patch set version 1 Please read Documentation/SubmittingPatches for how to properly label patches, don't make new things up, we have too many different developers (i.e. 4000+) for everyone to do their own unique thing. :) thanks, greg k-h