From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936967AbdAENWp (ORCPT ); Thu, 5 Jan 2017 08:22:45 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:49187 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754018AbdAENWi (ORCPT ); Thu, 5 Jan 2017 08:22:38 -0500 Date: Thu, 5 Jan 2017 16:21:06 +0300 From: Dan Carpenter To: Derek Robson Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, wsa+renesas@sang-engineering.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: ks7010: style fix, long lines Message-ID: <20170105132106.GG13756@mwanda> References: <20170104235616.21112-1-robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170104235616.21112-1-robsonde@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 12:56:16PM +1300, Derek Robson wrote: > Debug code had very long lines. > Reworked code to use several prints rather than one big print. > > Signed-off-by: Derek Robson > --- > drivers/staging/ks7010/ks_hostif.c | 32 +++++++++++++++++++++++++------- > 1 file changed, 25 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > index 1fbd495e5e63..70f8565acbeb 100644 > --- a/drivers/staging/ks7010/ks_hostif.c > +++ b/drivers/staging/ks7010/ks_hostif.c > @@ -190,13 +190,31 @@ int get_current_ap(struct ks_wlan_private *priv, struct link_ap_info_t *ap_info) > wireless_send_event(netdev, SIOCGIWAP, &wrqu, NULL); > } > DPRINTK(4, "\n Link AP\n"); > - DPRINTK(4, " bssid=%02X:%02X:%02X:%02X:%02X:%02X\n \ > - essid=%s\n rate_set=%02X,%02X,%02X,%02X,%02X,%02X,%02X,%02X\n channel=%d\n \ > - rssi=%d\n sq=%d\n capability=%04X\n", ap->bssid[0], ap->bssid[1], ap->bssid[2], ap->bssid[3], ap->bssid[4], ap->bssid[5], &(ap->ssid.body[0]), ap->rate_set.body[0], ap->rate_set.body[1], ap->rate_set.body[2], ap->rate_set.body[3], ap->rate_set.body[4], ap->rate_set.body[5], ap->rate_set.body[6], ap->rate_set.body[7], ap->channel, ap->rssi, ap->sq, ap->capability); > - DPRINTK(4, "\n Link AP\n rsn.mode=%d\n rsn.size=%d\n", > - ap_info->rsn_mode, ap_info->rsn.size); > - DPRINTK(4, "\n ext_rate_set_size=%d\n rate_set_size=%d\n", > - ap_info->ext_rate_set.size, ap_info->rate_set.size); > + DPRINTK(4, " bssid="); > + DPRINTK(4, "%02X:", ap->bssid[0]); No. You can't do this. Every DPRINTK() prints the function name and some other stuff so it would totally mess up the output. regards, dan carpenter