From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbdAFLDr (ORCPT ); Fri, 6 Jan 2017 06:03:47 -0500 Received: from 8bytes.org ([81.169.241.247]:46390 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755438AbdAFK7s (ORCPT ); Fri, 6 Jan 2017 05:59:48 -0500 Date: Fri, 6 Jan 2017 11:59:45 +0100 From: Joerg Roedel To: Eric Auger Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com Subject: Re: [PATCH v6 01/18] iommu/dma: Allow MSI-only cookies Message-ID: <20170106105945.GK17255@8bytes.org> References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-2-git-send-email-eric.auger@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483643086-2883-2-git-send-email-eric.auger@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 05, 2017 at 07:04:29PM +0000, Eric Auger wrote: > struct iommu_dma_cookie { > - struct iova_domain iovad; > - struct list_head msi_page_list; > - spinlock_t msi_lock; > + union { > + struct iova_domain iovad; > + dma_addr_t msi_iova; > + }; > + struct list_head msi_page_list; > + spinlock_t msi_lock; > + enum iommu_dma_cookie_type type; Please move the type to the beginning of the struct and add a comment how the type relates to the union. Joerg