From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033704AbdAFMte (ORCPT ); Fri, 6 Jan 2017 07:49:34 -0500 Received: from 8bytes.org ([81.169.241.247]:46546 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032224AbdAFMtM (ORCPT ); Fri, 6 Jan 2017 07:49:12 -0500 Date: Fri, 6 Jan 2017 13:48:16 +0100 From: Joerg Roedel To: Auger Eric Cc: eric.auger.pro@gmail.com, christoffer.dall@linaro.org, marc.zyngier@arm.com, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, tglx@linutronix.de, jason@lakedaemon.net, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, drjones@redhat.com, linux-kernel@vger.kernel.org, pranav.sawargaonkar@gmail.com, iommu@lists.linux-foundation.org, punit.agrawal@arm.com, diana.craciun@nxp.com, gpkulkarni@gmail.com, shankerd@codeaurora.org, bharat.bhushan@nxp.com, geethasowjanya.akula@gmail.com Subject: Re: [PATCH v6 07/18] iommu: Implement reserved_regions iommu-group sysfs file Message-ID: <20170106124816.GQ17255@8bytes.org> References: <1483643086-2883-1-git-send-email-eric.auger@redhat.com> <1483643086-2883-8-git-send-email-eric.auger@redhat.com> <20170106110039.GL17255@8bytes.org> <888d3750-817c-77d1-8154-e77cf8c3ad4b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <888d3750-817c-77d1-8154-e77cf8c3ad4b@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 06, 2017 at 12:46:05PM +0100, Auger Eric wrote: > On 06/01/2017 12:00, Joerg Roedel wrote: > > I think it also makes sense to report the type of the reserved region. > > What is the best practice in that case? Shall we put the type enum > values as strings such as: > - direct > - nomap > - msi > > and document that in Documentation/ABI/testing/sysfs-kernel-iommu_groups Yes, a string would be good. An probably 'reserved' is a better name than nomap? Joerg