From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S966765AbdAFP7Y (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 10:59:24 -0500
Received: from mga07.intel.com ([134.134.136.100]:59002 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S966710AbdAFP7S (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 10:59:18 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,325,1477983600"; 
   d="scan'208";a="1090748466"
Date: Fri, 6 Jan 2017 07:58:31 -0800
From: "Raj, Ashok" <ashok.raj@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: Alexander Alemayhu <alexander@alemayhu.com>,
        Daniel J Blueman <daniel@quora.org>,
        Paul Menzel <pmenzel@molgen.mpg.de>, tony.luck@intel.com,
        linux@leemhuis.info, len.brown@intel.com,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>,
        ashok.raj@intel.com
Subject: Re: Dell XPS13: MCE (Hardware Error) reported
Message-ID: <20170106155831.GA30814@otc-nc-03>
References: <CAMVG2stPPdkFUt=6z1tXiQwsY8JysdqPU+XYPNYF72Gs46neqw@mail.gmail.com>
 <CAMVG2suPLS315HecNrAu9GB9wSYEr276V0utBbOO0vi9yapBQQ@mail.gmail.com>
 <20170105201034.GA15245@gmail.com>
 <20170105203146.egi3kveypclmwllp@pd.tnic>
 <20170105232800.GA82321@otc-brkl-03>
 <20170105235611.yj4ayqpg2ysibeqy@pd.tnic>
 <20170106012617.GA28713@otc-nc-03>
 <20170106111617.jjgo2322byhuujvy@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170106111617.jjgo2322byhuujvy@pd.tnic>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Boris

On Fri, Jan 06, 2017 at 12:16:17PM +0100, Borislav Petkov wrote:
> On Thu, Jan 05, 2017 at 05:26:17PM -0800, Raj, Ashok wrote:
> > Agree, since we have both a log and another agent to deal with it, it makes
> > no good reason to continue... Will pass this along, and have someone look at
> > cleaning this up.
> 
> Like this?

That was quick :-).

> -	if (therm_throt_process(msr_val & THERM_STATUS_PROCHOT,
> -				THERMAL_THROTTLING_EVENT,
> -				CORE_LEVEL) != 0)

Looks like we don't need a return value from therm_throt_process(),
we can fix that as void as well.

Otherwise it looks good. 

> +	therm_throt_process(msr_val & THERM_STATUS_PROCHOT,
> +			    THERMAL_THROTTLING_EVENT,
> +			    CORE_LEVEL);
>  

Cheers,
Ashok