From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938189AbdAFUJG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 6 Jan 2017 15:09:06 -0500
Received: from mx1.redhat.com ([209.132.183.28]:58838 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S938130AbdAFUI4 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 6 Jan 2017 15:08:56 -0500
Date: Fri, 6 Jan 2017 15:08:55 -0500
From: Mike Snitzer <snitzer@redhat.com>
To: David Binderman <dcb314@hotmail.com>
Cc: "agk@redhat.com" <agk@redhat.com>,
        "dm-devel@redhat.com" <dm-devel@redhat.com>,
        "shli@kernel.org" <shli@kernel.org>,
        "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: drivers/md/dm-mpath.c:478: suspicious code ?
Message-ID: <20170106200855.GA15627@redhat.com>
References: <VI1PR08MB10227DFB2600B24201D3209D9C630@VI1PR08MB1022.eurprd08.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR08MB10227DFB2600B24201D3209D9C630@VI1PR08MB1022.eurprd08.prod.outlook.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 06 Jan 2017 20:08:57 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 06 2017 at 12:52pm -0500,
David Binderman <dcb314@hotmail.com> wrote:

> Hello there,
> 
> drivers/md/dm-mpath.c:478:19: warning: decrement of a boolean expression [-Wbool-operation]
> 
> Source code is
> 
>    } while (bypassed--);
> 
> Suggest code rework. Maybe a boolean / int type mixup ?

Yeah, should be cleaned up.

Thanks for reporting this.