Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines

Wolfram Sang
2017-01-07T12:49:45Z

[-- Attachment #1: Type: text/plain, Size: 787 bytes --]

> > > > > + if (!known_i2c_address) {
> > > > > + dev_warn(&priv->pci_dev->dev,
> > > > > + "Accelerometer lis3lv02d i2c device is present "
> > > > > + "but its i2c address is unknown, skipping ...\n");
> > > >
> > > > You are probably well aware of this, but checkpatch prefers
> > > > keeping long log messages in one line. I am pointing it out
> > > > just in case.
> > >
> > > Yes, but I do not know how to fix it. Splitting message into two
> > > lines generates warning. Having long line generates warning too.
> >
> > Weird, checkpatch does not protest on my machine when the log message
> > is written on a single line...
>
> I hope that i2c maintainers decide how to format that line.

Make it one line saying "accelerometer address unknown"?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]