From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937654AbdAGNIp (ORCPT ); Sat, 7 Jan 2017 08:08:45 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47642 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932228AbdAGNIf (ORCPT ); Sat, 7 Jan 2017 08:08:35 -0500 Date: Sat, 7 Jan 2017 14:08:53 +0100 From: Greg Kroah-Hartman To: sumit negi Cc: Ian Abbott , H Hartley Sweeten , Aniket Sharma , Ravishankar Karkala Mallikarjunayya , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Stagging :Comedi :Fixed Camel Case Style issue Message-ID: <20170107130852.GA27944@kroah.com> References: <20170107101805.3518-1-er20snegi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170107101805.3518-1-er20snegi@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 07, 2017 at 03:48:05PM +0530, sumit negi wrote: > Fixed a camel style issue. Really? Look at what you changed: > -extern const struct comedi_lrange range_0_20mA; > -extern const struct comedi_lrange range_4_20mA; > -extern const struct comedi_lrange range_0_32mA; > +extern const struct comedi_lrange range_0_20ma; > +extern const struct comedi_lrange range_4_20ma; > +extern const struct comedi_lrange range_0_32ma; mA means something, correct? Why did you change that? checkpatch is a _hint_, you still always have to use your brain. Don't blindly make changes that make no sense, like this one :( sorry, greg k-h