linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH] usb: storage: ene_ub6250: remove unused variable
Date: Sun, 8 Jan 2017 12:31:52 +0100	[thread overview]
Message-ID: <20170108113152.GA15608@kroah.com> (raw)
In-Reply-To: <58717993.3010906@gmail.com>

On Sat, Jan 07, 2017 at 11:28:19PM +0000, Sudip Mukherjee wrote:
> On Thursday 05 January 2017 06:36 PM, Greg Kroah-Hartman wrote:
> > On Sun, Dec 18, 2016 at 10:34:31PM +0000, Sudip Mukherjee wrote:
> > > The variable Newblk was only being assigned some value but was never
> > > used after that.
> > > 
> > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
> > > ---
> > >   drivers/usb/storage/ene_ub6250.c | 2 --
> > >   1 file changed, 2 deletions(-)
> > 
> > from and signed-off-by does not match :(
> > 
> > Same with your other usb patch...
> > 
> 
> I can add the From: tag in the patch. But this is from the last time we had
> this same conversation.
> 
> http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-February/065121.html

I can't remember an email thread from last week, or even yesterday, let
alone from almost a year ago.

I suggest you fix your email server so we don't have the same
conversation next week, or use the From: line in the patch which is what
I am expecting people to do for crappy email servers like this. :)

thanks,

greg k-h

      reply	other threads:[~2017-01-08 11:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-18 22:34 [PATCH] usb: storage: ene_ub6250: remove unused variable Sudip Mukherjee
2017-01-05 18:36 ` Greg Kroah-Hartman
2017-01-07 23:28   ` Sudip Mukherjee
2017-01-08 11:31     ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170108113152.GA15608@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).