linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: New attempt at adding an disassembler to perf
Date: Sun, 8 Jan 2017 15:21:37 +0100	[thread overview]
Message-ID: <20170108142137.GF31186@krava> (raw)
In-Reply-To: <20170103090029.17621-1-andi@firstfloor.org>

On Tue, Jan 03, 2017 at 01:00:25AM -0800, Andi Kleen wrote:
> A native disassembler in perf is very useful, in particular with perf script to trace 
> instruction streams, but also for other analysis. Previously I attempted
> to do this using the udis86 library, but that was rejected because:
> - udis86 was not maintained anymore and lacking recent instructions
> - udis86 is dynamically linked and gives a runtime dependency.
> Doing this needs a full disassembler, not just a decoder, so the existing
> instruction decoder cannot be used without major changes.
> 
> This patchkit addresses these issues.  Intel recently released an open source version
> of the XED disassembler library, which is used in many other Intel software.
> It is very well maintained, uptodate, and supports static linking, so there is no
> runtime dependency. This version adds XED support to perf, and uses it to implement
> assembler output in perf script. It also fixes a range of issues in the previous
> version, see the individual change logs.
> 
> Available in 
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/xed-3
> 
> v1: First post of XED version

I tested and it looks ok.. once the xed detection is sorted out
I'd ack it

thanks,
jirka

  parent reply	other threads:[~2017-01-08 14:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-03  9:00 New attempt at adding an disassembler to perf Andi Kleen
2017-01-03  9:00 ` [PATCH 1/4] perf, tools: Add probing for xed Andi Kleen
2017-01-03 14:58   ` Jiri Olsa
2017-01-03 15:10     ` Arnaldo Carvalho de Melo
2017-01-03 15:11     ` Andi Kleen
2017-01-03 18:39       ` Arnaldo Carvalho de Melo
2017-01-03 19:48         ` Jiri Olsa
2017-01-08 14:19   ` Jiri Olsa
2017-01-08 14:20   ` Jiri Olsa
2017-01-10  0:56     ` Andi Kleen
2017-01-03  9:00 ` [PATCH 2/4] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-08 14:20   ` Jiri Olsa
2017-01-03  9:00 ` [PATCH 3/4] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-03  9:00 ` [PATCH 4/4] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-08 14:19   ` Jiri Olsa
2017-01-09 19:14     ` Andi Kleen
2017-01-08 14:20   ` Jiri Olsa
2017-01-08 14:21 ` Jiri Olsa [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-01-19  1:41 New attempt at adding an disassembler to perf Andi Kleen
2017-01-19 15:36 ` Jiri Olsa
2017-01-19 16:54   ` Andi Kleen
2017-01-20 13:22 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170108142137.GF31186@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).