From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162268AbdAHOVs (ORCPT ); Sun, 8 Jan 2017 09:21:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60228 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939168AbdAHOVk (ORCPT ); Sun, 8 Jan 2017 09:21:40 -0500 Date: Sun, 8 Jan 2017 15:21:37 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: New attempt at adding an disassembler to perf Message-ID: <20170108142137.GF31186@krava> References: <20170103090029.17621-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103090029.17621-1-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 08 Jan 2017 14:21:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 01:00:25AM -0800, Andi Kleen wrote: > A native disassembler in perf is very useful, in particular with perf script to trace > instruction streams, but also for other analysis. Previously I attempted > to do this using the udis86 library, but that was rejected because: > - udis86 was not maintained anymore and lacking recent instructions > - udis86 is dynamically linked and gives a runtime dependency. > Doing this needs a full disassembler, not just a decoder, so the existing > instruction decoder cannot be used without major changes. > > This patchkit addresses these issues. Intel recently released an open source version > of the XED disassembler library, which is used in many other Intel software. > It is very well maintained, uptodate, and supports static linking, so there is no > runtime dependency. This version adds XED support to perf, and uses it to implement > assembler output in perf script. It also fixes a range of issues in the previous > version, see the individual change logs. > > Available in > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git perf/xed-3 > > v1: First post of XED version I tested and it looks ok.. once the xed detection is sorted out I'd ack it thanks, jirka