From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756243AbdAHOZE (ORCPT <rfc822;w@1wt.eu>);
        Sun, 8 Jan 2017 09:25:04 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60550 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751303AbdAHOYz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Jan 2017 09:24:55 -0500
Date: Sun, 8 Jan 2017 15:24:52 +0100
From: Jiri Olsa <jolsa@redhat.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jiri Olsa <jolsa@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf tools: Create libdir directory before installing
 libperf-jvmti.so
Message-ID: <20170108142452.GA17926@krava>
References: <1483741088-13543-1-git-send-email-labbott@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1483741088-13543-1-git-send-email-labbott@redhat.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Sun, 08 Jan 2017 14:24:56 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 06, 2017 at 02:18:08PM -0800, Laura Abbott wrote:
> The install command for libperf-jvmti.so does not check if libdir exists
> before installing. This means that when the install command is run:
> 
> install libperf-jvmti.so '/tmp/test_root/usr/lib64';
> 
> libperf-jvmti.so will get installed to /usr/lib64 as a file and break further
> installation. Fix this by ensuring the directory gets created first.
> 
> See https://bugzilla.redhat.com/show_bug.cgi?id=1410296
> 
> Fixes: d4dfdf00d43e ("perf jvmti: Plug compilation into perf build")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
> ---
> For full disclosure, Fedora is setting NO_JVMTI but this should still be fixed
> to allow it to be turned on in the future.

Acked-by: Jiri Olsa <jolsa@redhat.com>

I have patches for fedora to install that, looks like you guys
are not planning to enable it, so I'll post it soon ;-)

thanks,
jirka