From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968658AbdAHS62 (ORCPT ); Sun, 8 Jan 2017 13:58:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57200 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968381AbdAHS6H (ORCPT ); Sun, 8 Jan 2017 13:58:07 -0500 Date: Sun, 8 Jan 2017 19:58:00 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, mingo@kernel.org, Andi Kleen Subject: Re: [PATCH 03/11] perf, tools: Add support for parsing uncore json files Message-ID: <20170108185800.GD14072@krava> References: <20170103150833.6694-1-andi@firstfloor.org> <20170103150833.6694-4-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170103150833.6694-4-andi@firstfloor.org> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Sun, 08 Jan 2017 18:58:03 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 07:08:25AM -0800, Andi Kleen wrote: SNIP > /* > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 29c254dd7380..8bffe99d8e3f 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -229,11 +229,13 @@ static int perf_pmu__parse_snapshot(struct perf_pmu_alias *alias, > } > > static int __perf_pmu__new_alias(struct list_head *list, char *dir, char *name, > - char *desc, char *val, char *long_desc, > - char *topic) > + char *desc __maybe_unused, char *val, no need for 'desc' to be __maybe_unused jirka