From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759967AbdAILiO (ORCPT ); Mon, 9 Jan 2017 06:38:14 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44102 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965690AbdAIL1z (ORCPT ); Mon, 9 Jan 2017 06:27:55 -0500 Date: Mon, 9 Jan 2017 12:28:15 +0100 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: stable@vger.kernel.org, Thomas Gleixner , Dan Streetman , Andrew Morton , linux-mm@kvack.org, Michal Hocko , Yu Zhao , linux-kernel@vger.kernel.org Subject: Re: [PATCH] stable-fixup: hotplug: fix unused function warning Message-ID: <20170109112815.GA8187@kroah.com> References: <20170109104811.1453295-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170109104811.1453295-1-arnd@arndb.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 09, 2017 at 11:47:50AM +0100, Arnd Bergmann wrote: > The backport of upstream commit 777c6e0daebb ("hotplug: Make > register and unregister notifier API symmetric") to linux-4.4.y > introduced a harmless warning in 'allnoconfig' builds as spotted by > kernelci.org: > > kernel/cpu.c:226:13: warning: 'cpu_notify_nofail' defined but not used [-Wunused-function] > > So far, this is the only stable tree that is affected, as linux-4.6 and > higher contain commit 984581728eb4 ("cpu/hotplug: Split out cpu down functions") > that makes the function used in all configurations, while older longterm > releases so far don't seem to have a backport of 777c6e0daebb. > > The fix for the warning is trivial: move the unused function back > into the #ifdef section where it was before. > > Link: https://kernelci.org/build/id/586fcacb59b514049ef6c3aa/logs/ > Fixes: 1c0f4e0ebb79 ("hotplug: Make register and unregister notifier API symmetric") in v4.4.y > Signed-off-by: Arnd Bergmann > --- > kernel/cpu.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) Thanks for this, now applied. greg k-h